Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

crengine: don't compile unused code #1675

Merged

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Oct 24, 2023

Depends on koreader/crengine#542.


This change is Reviewable

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Makes sense but I'm not entirely sure how that corresponds to the discussion over there atm. :-)

@benoit-pierre benoit-pierre mentioned this pull request Oct 26, 2023
@Frenzie
Copy link
Member

Frenzie commented Oct 30, 2023

Anything else to do here?

@benoit-pierre benoit-pierre force-pushed the pr/no_crengine_unused_code_compilation branch from cced8a4 to 221b1dd Compare October 30, 2023 22:37
@benoit-pierre benoit-pierre marked this pull request as ready for review October 30, 2023 23:11
@benoit-pierre
Copy link
Contributor Author

Anything else to do here?

Nope, should be ready.

@Frenzie Frenzie merged commit 3772845 into koreader:master Oct 31, 2023
2 checks passed
@benoit-pierre benoit-pierre deleted the pr/no_crengine_unused_code_compilation branch October 31, 2023 07:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants