Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[question] about title in the full status bar #3994

Closed
cramoisi opened this issue Jun 4, 2018 · 18 comments

Comments

Projects
None yet
3 participants
@cramoisi
Copy link
Contributor

commented Jun 4, 2018

  • KOReader version: all
  • Device: all

(from mobileread)

Do you know if there is a possibility to change the size of the font when using a full status bar (where the title dwelt).

I spot a crengine.page.header.font.size=22 in cr3.ini but changing the value doesn't do anything on the emu even if it seems to deal with it.

https://github.com/koreader/crengine/blob/ac7470a3bc230e6e934125d1f5681f51d8961729/crengine/src/lvdocview.cpp#L3156-L3163

@cramoisi cramoisi changed the title [question] [question] about title in the full status bar Jun 4, 2018

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2018

That setting in cr3.ini seems indeed not to be used, and I don't really know how that cr3.ini works, or why it works for some and not for others.
A quick and easy way to have it applied is to do it from koreader, for example with:

--- a/frontend/document/credocument.lua
+++ b/frontend/document/credocument.lua
@@ -124,6 +124,10 @@ function CreDocument:init()
     -- adjust font sizes according to screen dpi
     self._document:adjustFontSizes(Screen:getDPI())

+    if G_reader_settings:readSetting("cre_status_font_size") then
+        self._document:setIntProperty("crengine.page.header.font.size", G_reader_settings:readSetting("cre_status_font_size"))
+    end
+
     -- set fallback font face
     self._document:setStringProperty("crengine.font.fallback.face",
         G_reader_settings:readSetting("fallback_font") or self.fallback_font)

so one could add to its settings.reader.lua: ["cre_status_font_size"] = 40,

(But who still wants that ugly top bar when we have a super configurable super nice bottom minibar? :)

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2018

@poire-z not me ; I was just passing through a question from mobileread : https://www.mobileread.com/forums/showthread.php?t=297545

But now you speak of it ; it would be a delight to have "title : chapter" display option in the minibar (but i probably wouldn't use it anyway)

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2018

it's closed then. @poire-z https://www.mobileread.com/forums/showthread.php?t=297932 (as I know you like robert dict)

@cramoisi cramoisi closed this Jun 4, 2018

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 4, 2018

I'll probably stick the above setting in a futur PR, so it's just there for people who'd like that.
I spent enough time tweaking the Robert 2003 and 2010 that I don't feel like doing that again on some new dict :)
But if you post a screenshot of what you get for, let's say the word lecteur, I can compare and see if the adventure is worth it :)

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 4, 2018

for now it's quite nothing I have yet to make some css functional =-) But as it's intended for nickel the thing is quite "simple" not much more than ol , li, b and i (and I had to get rid of ol/li because they didn't match). But you can call it "an usable raw file"

@KenMaltby

This comment has been minimized.

Copy link

commented Jun 5, 2018

"cre_status_font_size" doesn't sound like it would be for the "Full" Progress bar setting resulting display at the top of each page. Is it a cre3 thing?

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

@KenMaltby : yup, this bar is a cr3 thing. I didn't expect it at first (was thinking it was just as easily configurable as the bottom minibar)

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

@poire-z : just to say : tested and working.

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2018

So, any better name for this hidden setting?

cre_status_font_size
cre_header_font_size
cre_header_status_font_size
full_status_bar_font_size

It's just to set the internal crengine setting name crengine.page.header.font.size

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

one of these two ? (mostly because they are the most explicit ) :

cre_header_status_font_size
full_status_bar_font_size
@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

not related
reader_2018-jun-05_112449

@poire-z

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2018

A bit stripped down from those I have:
image
image
(See #3585 for the lua function trick to parse & tweak a HTML dict output with lua code.)

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

Yup, I compared too to these (I asked you about them at this time). Hence the "micro" in the title :)

The 2007 is good but there is a lot of def which are in the .syn file (and shouldn't be there). I extracted them but since I don't know how to recompile with a syn file (for the synonyms), I can't get it back and functional.

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

This is what if got from my converted amazon robert-dixel to stardict :

reader_2018-jun-05_130802

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 5, 2018

I remember I used penelope 3.1.3, with some modifications of mine, to ignore duplicates and deal with title words like "Travail, -aux", and may be some stuff with synonyms (it's quite old, and I don't want to put back my nose in it :) Sharing these modifications in case it may help you: penelope-3.1.3my.patch.txt

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Jun 5, 2018

great ! till now I used a serie of regexp for making a new line with the feminine form (or the synonym) and the definition (the same as the principal form). It does the trick but it's quite redundant.

@KenMaltby

This comment has been minimized.

Copy link

commented Jun 5, 2018

I guess cre3's use of the "Status" line term, could be a nod to the Android page design, where there is an info/menu bar at the top of every page. That could be looked at as a "Status" line. For within KOReader's UI, I like the "page header" term better. KOReader's "Status line" in this regard would be the mini-progress bar, at the bottom.

@poire-z

This comment has been minimized.

Copy link
Contributor

commented Jun 6, 2018

Can now be changed by manually adding to settings.reader.lua something like:
["cre_header_status_font_size"] = 60,

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.