Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

toggle front light on / off in the status bar and frontlight auto-activation ? #4923

Closed
cramoisi opened this issue Apr 15, 2019 · 25 comments

Comments

Projects
None yet
3 participants
@cramoisi
Copy link
Contributor

commented Apr 15, 2019

  • KOReader version: 2019.04-25 ... 2019-04-13
  • Device: KA1

1/ I updated to the last nightly yesterday. My status bar is set to display the frontlight intensity. I noticed that when I toggle the frontlight to on with a bottom left tap, the "off" in the status bar is not updated but It was before. Is this behaviour intended ? The status bar update the value after a page turn.

2/ After a sleep and wake up I also noticed that the frontlight reactivates itself but even if it was off before I put the device to sleep... and the auto frontlight plugin is off...

Any idea ?

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

my persistent says : "KOBO_LIGHT_ON_START = -1"

@Frenzie

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

The second will be fixed by #4921 (comment). Pinging @NiLuJe about the status thing.

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@Frenzie : oh great !

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

There is also something weird when I first boot koreader : I can't turn the light on with a left bottom tap action (the option is correctly set). Koreader keeps to say : the "Frontlight is off" after each tap. It only enables when I set it the brightness to 1 with the frontlight menu. Even the Toggle doesn't work there before manually set the light from 0 to 1.

@Frenzie

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Is that from KSM or Nickel?

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@ Frenzie : when I come from nickel using KFmon.

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

After exiting koreader to nickel and relaunch koreader with kfmon, the setting in the frontlight menu are wiped : min Brightness is set to 0 so the toggle doesn't work. Once you manually change it, it's ok but it should keep the value and this value should be at least 1 if nothing set

@Frenzie Frenzie added bug Kobo labels Apr 15, 2019

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

So I guess "KOBO_LIGHT_ON_START = -1" is broken (or there is no data found)

@Frenzie

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

There were some changes in #4871. That doesn't seem to feature in the diff though.

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

yeah, and I forgot to record the build I was before update to last

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

What's the intended behavior with -1?

EDIT: Okay, back at a computer, KOReader's own settings, right. No idea why that'd break ;).
Unless you exit with the light off, possibly.

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

So, @cramoisi: What are your usual frontlight settings, in KOReader, to trigger that startup behavior?

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Actually, the footer thing is not new, and it wasn't refreshing from the FL gesture control either ;).

(But it is something I also broke, just, err, earlier ;D).

NiLuJe added a commit to NiLuJe/koreader that referenced this issue Apr 15, 2019

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Speaking of the FL gesture, it's now disabled in the FM. IIRC, that's new, was that an intended behavior, @Frenzie ?

(Not particularly complaining, as this is disabled on all my devices ;p).

@Frenzie

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Umm, I never touched the plugin. :-)

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

I have no idea how it works, just though it might have been something to do with the multiswipe stuff, since I remember one commit mentioning inhibiting some stuff in the FM ;).

@NiLuJe NiLuJe closed this in 33946aa Apr 15, 2019

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@NiLuJe Sorry, I was afk :/ But you figured everything out I see

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

(It was not a problem of exiting with light on or off. Did you were able to replicate the behaviour ? )

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

@NiLuJe : the toggle thing is still non-functional after applying your PR

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

with KOBO_LIGHT_ON_START = -1 (koreader's values only)

  1. Set my frontlight value to 50 (from the frontlight menu)
  2. Toggle on, toggle off
  3. open a book, toggle on : it set from off (0) to 50
  4. exit a book, exit koreader to nickel
  5. launch koreader with KFMon, directly in the book
  6. Toggle doesn't work (left bottom tap or the toggle button in the frontlight menu)
  7. the frontlight menu : the previous value set to 50 is now set to 0
  8. Toggle set from 0 to 0, so it's always off, and the value need to be readjusted manually

with KOBO_LIGHT_ON_START = 1 (minimal light value to 1)

  1. frontlight is always turned on when launching koerader, even if it was off before quitting (so I don't want to use it)
@Frenzie

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

I may have also noticed something odd with the frontlight not toggling until I manually set it to 1 but unless I'm in testing mode I mainly care about it being off.

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 15, 2019

I did some test and the points 7 and 8 can't be replicated "manually" : setting a value in the frontlight menu re-enable the toggle functionality and even if you set 0 as a min value, the toggle will toggle from 0 to 1 (as it worked before). Also, the warmth setting is also reset :/ Even if you "save" it before.

Setting KOBO_LIGHT_ON_START = 0 leads to the same result

I only use the frontlight (set on 1) with left bottom tap when I woke up during the night to read when it's pitch-dark (easy to turn it on without much hassle) so if I need to turn on the light to set the damn thing or to remember if I did exit koreader before, it defeats the purpose of the whole thing :D

@NiLuJe

This comment has been minimized.

Copy link
Member

commented Apr 15, 2019

Okay, I can reproduce that if, and only if, I exit/restart KOReader with the FL off.

@NiLuJe NiLuJe reopened this Apr 15, 2019

NiLuJe added a commit to NiLuJe/koreader that referenced this issue Apr 15, 2019

Don't override hw_intensity when we start with the FL off
Fix koreader#4923

First toggle is still be funky, but it essentially recovers.

@NiLuJe NiLuJe closed this in #4924 Apr 15, 2019

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

it doesn't change a thing for me :/ the toggle is still broken, and I got this even if I exit (or restart or reboot) with the FL manually set on a value.

@cramoisi

This comment has been minimized.

Copy link
Contributor Author

commented Apr 16, 2019

ok, somehow, it works after ota update ! thanks !

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
You can’t perform that action at this time.