Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Nickel indexing KOReader icons after FW 4.17 update #5430

Closed
anarcat opened this issue Sep 26, 2019 · 21 comments
Closed

Nickel indexing KOReader icons after FW 4.17 update #5430

anarcat opened this issue Sep 26, 2019 · 21 comments

Comments

@anarcat
Copy link
Contributor

@anarcat anarcat commented Sep 26, 2019

  • KOReader version: v2015.11-1416-gb37ae2d
  • Device: Kobo Glo HD

Issue

During the last Nickel upgrade, something changed and now all the little icons, files and logos shipped with koreader show up in the Nickel database. It's pretty nasty because there are a lot of those tiny things and they make Nickel almost unusable.

Steps to reproduce

Not exactly sure: I just did the latest official upgrades from Kobo and, during its next rescan, it found all that garbage.

Now, I guess I'm running a very old version of koreader and should upgrade, but for some reason, the OTA upgrades don't work, so I'm stuck with this. I also suspect this problem also happens in later version, unless the way to deploy koreader radically changed since I last checked.

Thanks for any advice!

@anarcat
Copy link
Contributor Author

@anarcat anarcat commented Sep 26, 2019

for what it's worth, i just upgraded to the latest release, and nickel "lost" a bunch of those files, but still found files like:

anarcat@angela:Downloads(master)$ unzip -l koreader-kobo-v2019.09.3.zip | grep appbar
      509  2019-09-11 03:32   koreader/resources/icons/appbar.clear.reflect.horizontal.png
      536  2019-09-11 03:32   koreader/resources/icons/appbar.chevron.up.png
      369  2019-09-11 03:32   koreader/resources/icons/appbar.column.two.large.png
      412  2019-09-11 03:32   koreader/resources/icons/appbar.align.right.png
      555  2019-09-11 03:32   koreader/resources/icons/appbar.column.three.png
      806  2019-09-11 03:32   koreader/resources/icons/appbar.text.size.large.png
      343  2019-09-11 03:32   koreader/resources/icons/appbar.spacer.png
      518  2019-09-11 03:32   koreader/resources/icons/appbar.align.auto.png
      847  2019-09-11 03:32   koreader/resources/icons/appbar.magnify.browse.png
      455  2019-09-11 03:32   koreader/resources/icons/appbar.arrow.left.up.png
      582  2019-09-11 03:32   koreader/resources/icons/appbar.align.left.png
      604  2019-09-11 03:32   koreader/resources/icons/appbar.wifi.png
      356  2019-09-11 03:32   koreader/resources/icons/appbar.arrow.shift.png
      642  2019-09-11 03:32   koreader/resources/icons/appbar.cabinet.files.png
      690  2019-09-11 03:32   koreader/resources/icons/appbar.home.png
      856  2019-09-11 03:32   koreader/resources/icons/appbar.page.text.png
      525  2019-09-11 03:32   koreader/resources/icons/appbar.column.one.png
      353  2019-09-11 03:32   koreader/resources/icons/appbar.book.open.png
      528  2019-09-11 03:32   koreader/resources/icons/appbar.align.justify.png
      471  2019-09-11 03:32   koreader/resources/icons/appbar.arrow.enter.png
      549  2019-09-11 03:32   koreader/resources/icons/appbar.page.corner.bookmark.png
      614  2019-09-11 03:32   koreader/resources/icons/appbar.chevron.first.png
      891  2019-09-11 03:32   koreader/resources/icons/appbar.settings.large.png
      542  2019-09-11 03:32   koreader/resources/icons/appbar.column.two.png
      849  2019-09-11 03:32   koreader/resources/icons/appbar.settings.png
      164  2019-09-11 03:32   koreader/resources/icons/appbar.checkmark.thick.unchecked.png
      538  2019-09-11 03:32   koreader/resources/icons/appbar.chevron.left.png
      583  2019-09-11 03:32   koreader/resources/icons/appbar.globe.wire.png
     1160  2019-09-11 03:32   koreader/resources/icons/appbar.pokeball.png
      643  2019-09-11 03:32   koreader/resources/icons/appbar.crop.large.png
      521  2019-09-11 03:32   koreader/resources/icons/appbar.align.center.png
      379  2019-09-11 03:32   koreader/resources/icons/appbar.plus.png
      537  2019-09-11 03:32   koreader/resources/icons/appbar.chevron.right.png
      433  2019-09-11 03:32   koreader/resources/icons/appbar.checkmark.thick.png
      891  2019-09-11 03:32   koreader/resources/icons/appbar.tools.png
      625  2019-09-11 03:32   koreader/resources/icons/appbar.chevron.last.png
      744  2019-09-11 03:32   koreader/resources/icons/appbar.transform.rotate.right.large.png
      606  2019-09-11 03:32   koreader/resources/icons/appbar.grade.b.large.png
      407  2019-09-11 03:32   koreader/resources/icons/appbar.control.collapse.png
      391  2019-09-11 03:32   koreader/resources/icons/appbar.control.expand.png

dang... there are actually ~120 of those files according to nickel.

on the upside, this is making me use koreader much more because it obviously doesn't suffer from this problem. and i must say you folks rock: it's a great product and I thank you for your great work! :)

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 26, 2019

Way ahead of you ;).

(In case it wasn't clear, that was a hint that using the install scripts would have prevented the issue ;)).

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 26, 2019

I updated the wiki to mention this, for the unwary who'd still want to do it manually.

@Frenzie Frenzie added this to the 2019.10 milestone Sep 26, 2019
@Frenzie
Copy link
Member

@Frenzie Frenzie commented Sep 26, 2019

but for some reason, the OTA upgrades don't work

You're on a version that doesn't yet correctly detect point releases. That's usually fine but coincidentally not this month.

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 26, 2019

Note that tweaking the setting after the fact (i.e., for someone who updated the FW on an existing KOReader installation, doing it at any later time than the first USBMS session) will cause Nickel to delete the files in question when it purges them from its database (as part of the sidecar cleanup).

Which means you'll have to reinstall KOReader, because we kinda need those icons ;p.

Which also means that if you have other, custom stuff in hidden folders, well, back them up somewhere first ;).

TL;DR: Important to do it right the first time around ;).

Also, fucking up the regex can and will blacklist onboard entirely, which leads to... fun results :D. I, err, may have "tried" this a couple times ;p.

@Frenzie
Copy link
Member

@Frenzie Frenzie commented Sep 26, 2019

Btw, aren't there "only" ~60-70 icons and logos?

@anarcat
Copy link
Contributor Author

@anarcat anarcat commented Sep 26, 2019

TL;DR: Important to do it right the first time around ;).

Oops! Thanks for the heads up, I guess I need to reinstall all that stuff now. Ouch!

Btw, aren't there "only" ~60-70 icons and logos?

Yeah well, I guess I had more than just koreader in there... there's some vlavasoft things and so on... go figure.

i hope KSM survived...

@anarcat
Copy link
Contributor Author

@anarcat anarcat commented Sep 26, 2019

hum. so after reinstalling koreader and kfmon, i'm no better off: all the icons are back in full force. scratch that - i unzipped koreader in the wrong location (root instead of .adds), nevermind. :)

FWIW, it seems like the Kobo/Kobo eReader.conf config file was rewritten (the [section] blocks have been reordered) but the section is still there:

[FeatureSettings]
ExcludeSyncFolders=\\.(?!kobo|adobe).*?

Yet Nickel still sees those files. Not sure what's going on here...

BTW, I think it's really awesome just stepped in with a solution with ten minutes of me opening this bug report. It's really great, thanks!

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 27, 2019

Note that nickel only scans for content indexing after an USBMS session (and not at startup), which is both what gives us a window to set this after an update, and what makes this slightly more obscure if you miss that window.

Plus, there's no easy way (short of tailing the syslog) to know when the process is entirely done (there's no "importing content" screen for the purge process).

c.f, this post for more details with a similar issue ;).

@NiLuJe NiLuJe changed the title nickel found us! Nickel indexing KOReader icons after FW 4.17 update Sep 27, 2019
@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 27, 2019

Keeping this open (at least for a while) for documentation purposes ;).

@anarcat
Copy link
Contributor Author

@anarcat anarcat commented Sep 27, 2019

Keeping this open (at least for a while) for documentation purposes ;).

folks might want to "pin" this issue here so people see it first as well. that way people will see if even if it's closed. it's kind of a FAQ of sort. :)

@NiLuJe NiLuJe pinned this issue Sep 27, 2019
@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 27, 2019

@anarcat: Good idea, thanks! (I was thoroughly unaware of that feature ;p).

Does it also still appear in the autocomplete, even if it's closed, that way?

@anarcat
Copy link
Contributor Author

@anarcat anarcat commented Sep 27, 2019

Does it also still appear in the autocomplete, even if it's closed, that way?

... in the autocomplete? not sure what you mean there. but yes, i think it shows up as pinned even if it's closed...

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 27, 2019

The thing that auto-suggests already opened issues as you type the title of a new one (may have been/still be in beta ;p) ;).

@anarcat
Copy link
Contributor Author

@anarcat anarcat commented Sep 27, 2019

i think closed issues appear in autocomplete, yes. i don't think pinning has anything to do without it, however.

@Frenzie Frenzie removed this from the 2019.10 milestone Oct 12, 2019
@tigerinus
Copy link

@tigerinus tigerinus commented Nov 2, 2019

What's the solution to this? I see whole bunch of appbar.*.png in book list.

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Nov 2, 2019

That would be actually reading the links in my original answer for context? Which ultimately leads you here.

@pazos
Copy link
Member

@pazos pazos commented Nov 4, 2019

Closing this issue as it was fixed outside KO and its not something that KO needs to fix. I will leave the issue pinned!

@zwim
Copy link
Member

@zwim zwim commented Sep 1, 2021

Do we need this issue pinned? The last entry is really over a year old.

@Frenzie
Copy link
Member

@Frenzie Frenzie commented Sep 1, 2021

I'll unpin it, bit I'll blame you if a duplicate pops up next week. 🤣

@Frenzie Frenzie unpinned this issue Sep 1, 2021
@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Sep 2, 2021

It did come up this week in a discussion ;).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
6 participants