Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wallabag missing example settings file #7576

Closed
mediaformat opened this issue Apr 21, 2021 · 6 comments
Closed

Wallabag missing example settings file #7576

mediaformat opened this issue Apr 21, 2021 · 6 comments
Labels

Comments

@mediaformat
Copy link

Issue

I would like to manually configure Client access to Wallabag server, using settings/wallabag.lua as mentioned in the wiki.

The wiki suggests generating an empty wallabag.lua settings

you might prefer to save the empty settings and edit the config file directly in your installation directory's settings/wallabag.lua

However, on legacy Kindle devices attempting to save Wallabag server settings is not possible because the modal action defaults to Cancel, and lateral navigation to access Save is not functional.

Please add example wallabag.lua settings to the wiki.
A clear and concise description of what you'd like to happen.

I unsuccessfully tried to generate my own

return {
    ["server_url"] = "https://wallabag.example.com",
    ["client_id"] = "example123",
    ["client_secret"] = "example123",
    ["username"] = "user1",
    ["password"] = "pass1"
}

Additional context
Also the downloads directory doesn't seem configurable via settings/wallabag.lua

@Frenzie Frenzie added the NT Non Touch devices label Apr 21, 2021
@Frenzie
Copy link
Member

Frenzie commented Apr 21, 2021

Perhaps some other other ones are necessary as well.

-- we can read Lua syntax here!
return {
    ["wallabag"] = {
        ["articles_per_sync"] = 30,
        ["client_id"] = "",
        ["client_secret"] = "",
        ["download_queue"] = {},
        ["filter_tag"] = "",
        ["ignore_tags"] = "",
        ["is_archiving_deleted"] = false,
        ["is_auto_delete"] = false,
        ["is_delete_finished"] = true,
        ["is_delete_read"] = false,
        ["is_sync_remote_delete"] = false,
        ["password"] = "",
        ["remove_finished_from_history"] = false,
        ["server_url"] = "",
        ["username"] = "",
    },
}

@mediaformat
Copy link
Author

Thanks for the example!
I have added this (with my own server settings) to the /koreader/settings/wallabag.lua file, but when I attempt to Retrieve new articles from the server, the modal advises to Please configure the server settings and set a download folder.

I also tried placing the file at /settings/wallabag.lua, not sure why it's not being recognized.

@NiLuJe
Copy link
Member

NiLuJe commented Apr 25, 2021

Definitely inside the existing settings folder in koreader's folder (so, koreader/settings/wallabag.lua).

You'll need to restart KOReader, too (and, err, possibly do that without KOReader running at all in the first place, actually).

@mediaformat
Copy link
Author

I restarted KOReader and restarted the Kindle, and it isn't taking.

But the more I think about it, the less comfortable I am storing username and password in clear text like this.
A token would be better, but I guess that is an upstream issue: wallabag/wallabag#2800

@Frenzie
Copy link
Member

Frenzie commented Apr 26, 2021

You'll also need a ["directory"] = "/bla/bla/wallabag-or-something", then.

@Commodore64user
Copy link
Contributor

However, on legacy Kindle devices attempting to save Wallabag server settings is not possible because the modal action defaults to Cancel, and lateral navigation to access Save is not functional.

If i understand this correctly, this is another ticket that could be closed as well.

This predates comphill's magnificent updates so should work now...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

4 participants