Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wallabag plugin shouldn't delete articles by default #8936

Closed
anarcat opened this issue Mar 22, 2022 · 2 comments · Fixed by #9018
Closed

wallabag plugin shouldn't delete articles by default #8936

anarcat opened this issue Mar 22, 2022 · 2 comments · Fixed by #9018
Labels
Milestone

Comments

@anarcat
Copy link
Contributor

anarcat commented Mar 22, 2022

  • KOReader version: 2022.03
  • Device: Kobo Aura

Issue

By default, a well-configured Wallabag plugin will delete remote article when the reader has marked it as "finished". I think that's counter intuitive and dangerous: the file and the remote article will potentially then be deleted and lost forever.

Instead, the default should be to mark the remote article as read and, maybe, delete locally, but do not remotely delete by default unless explicitly opted in b y the user.

@Frenzie Frenzie added the Plugin label Mar 22, 2022
@Frenzie
Copy link
Member

Frenzie commented Mar 22, 2022

At a quick glance, presumably it would suffice to change this line.

self.is_delete_finished = true

@Frenzie Frenzie added this to the 2022.04 milestone Mar 22, 2022
@hrdl-github
Copy link
Contributor

Or this one, to mark it as read on the server:

self.is_archiving_deleted = false

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants