Version log and (limited) notifications log #10178
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Mar 3, 2023
| @@ -76,5 +78,28 @@ This allows selecting which to show or hide.]]), | |||
| end, | |||
| separator = true, | |||
| }, | |||
| { | |||
| text = _("Show past notifications"), | |||
| help_text = _("Show the text of past Notifications."), | |||
There was a problem hiding this comment.
Suggested change
| help_text = _("Show the text of past Notifications."), | |
| help_text = _("Show the text of past notifications."), |
Seems a redundant though? I'd basically the same.
There was a problem hiding this comment.
I will remove the help text.
poire-z
reviewed
Mar 4, 2023
poire-z
reviewed
Mar 5, 2023
frontend/version.lua
Outdated
Comment on lines
101
to
109
|
|
||
| if not last_log_line then -- empty log file | ||
| return "" | ||
| end | ||
| else -- log file does not exist or can not be opened | ||
| return "" | ||
| end | ||
|
|
||
| return last_log_line |
There was a problem hiding this comment.
Can probably be simplified to just:
return last_log_line or ""
poire-z
approved these changes
Mar 5, 2023
poire-z
changed the title
NiLuJe
approved these changes
Mar 5, 2023
There was a problem hiding this comment.
Reviewed 5 of 6 files at r4, 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 6 unresolved discussions (waiting on @Frenzie and @zwim)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the successor to #10160
This change is