-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Feature: Added the possibility to export using kindle's myClippings f… #10263
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
I'd very much like this to be hidden behind a |
I understand the dislike for the format, but I think it's mainly a "middle step" to allow people to use tools that parse that kind of file. A kind of extra compatibility feature, as kindles have quite a bit of market share. A standard across software, even if a bad one, could be nice to have, so we can avoid remaking the same tools multiple times :') For example, there is an Obsidian notes plugin that then allows you to orderly import the highlights and notes incrementally (ignoring highlights you already have imported) and with a custom template that you can specify, as well as splitting them on a one-note-per-book basis. Locking it behind a "on kindle only" would make for a bit on inconsistency to me across versions (given I'm using tools that parse that format, I'd like it on all platforms... Pdfs suck on smaller e-ink readers, so Koreader on desktop is much better), which I never understand very well when it comes to software... That said, yeah, this format makes no sense as a "final product", so I'd totally see if members of Koreader would push against this feature. :') I made the PR before checking for other issues and seeing a similar issue discarded before - mainly because I needed to use the tool and wanted to see if I could make my way through an unknown repo and make changes - and later saw the maintainer that disapproved of it suggested making new tools that parse Koreader's format. If the members find it more interesting, we could work towards having a user-facing template that can be modified from them for some of the formats (markdown?), so that you could use placeholders like "---/n{{page}} - {{date}}/n/n> {{highlight}}\n\n{{note}}" for example, although sharing the option across devices would require you to manually save it somewhere, as a user. Super thanks for considering it and fixing up the code style 🌸 |
468ca22
to
44c8dc5
Compare
Fair enough (I was under the assumption that there were very few actually useful tools built around this specific format, which colored my initial response) ;). |
Thanks for the benefit of the doubt and reading :) And other tools: There's even a whole service that takes care of handling myClippings for people https://my.clippings.io/ 🤣 Amazon did such a "great job" with their exports :') |
44c8dc5
to
afabf2d
Compare
Thanks for the catch on remaining "myClippings" and love the attention to naming 🥰 |
afabf2d
to
181fc2c
Compare
I guess it doesn't make much sense to export a single document with this exporter. Anyhow, did you tested it? does it work (ie: doesn't crash, produces an expected output)? |
Added a bug fix: The previous This means that files that use the same extension would get written one after the other, in the same file. By adding a new property to the model Following this fix the "MyClippings" file will now be called |
Oh wow, how did I miss this jewel :D I would probably find this really useful. When using Kindle PW3 I used KindleMate to extract MyClippings.txt info in one tweakable format. Now I can add all my KOReader-read books to this bunch :D |
Super happy this will help you |
Solves FR #10262
This adds the "MyClippings" option when exporting your highlights.
The code of
target/myClippings.lua
is similar to that oftarget/text.lua
.Also updated
main.lua
to show the new option.This formatting is recognized as a kindle's
myClippings.txt
file.This change is