kindle voyage no framework launch whispertouch button activation #10290
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
Apr 2, 2023
spec/unit/device_spec.lua
Outdated
| } | ||
| end | ||
| } | ||
| package.loaded['liblipclua'] = mock_lipc |
There was a problem hiding this comment.
(Meaning double quotes instead of single quotes for string literals ;)).
Frenzie
reviewed
Apr 2, 2023
NiLuJe
reviewed
Apr 2, 2023
Comment on lines
+802
to
+807
| -- reenable WhisperTouch keys when started without framework | ||
| if self.framework_lipc_handle then | ||
| self.framework_lipc_handle:set_int_property("com.lab126.deviced", "fsrkeypadEnable", 1) | ||
| self.framework_lipc_handle:set_int_property("com.lab126.deviced", "fsrkeypadPrevEnable", 1) | ||
| self.framework_lipc_handle:set_int_property("com.lab126.deviced", "fsrkeypadNextEnable", 1) | ||
| end |
This comment was marked as off-topic.
This comment was marked as off-topic.
Sorry, something went wrong.
There was a problem hiding this comment.
Oh, wait, this isn't the main init, but the Voyage-specific one, never mind me, everything's fine :D.
yparitcher
approved these changes
Apr 2, 2023
NiLuJe
approved these changes
Apr 5, 2023
There was a problem hiding this comment.
Reviewed 1 of 2 files at r1, 1 of 1 files at r2, all commit messages.
Reviewable status: all files reviewed, 2 unresolved discussions (waiting on @doremiyeon and @Frenzie)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@NiLuJe as mentioned in the forum post
https://www.mobileread.com/forums/showpost.php?p=4310654&postcount=7
#9419
This change is