-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix some screen refresh effects #10306
Conversation
Hum, what does this have to do with toggling Wi-Fi, since this is the standby scheduler? (If it "fixes" anything, this is just because of the added delay this incurs, which is why I'm not a fan of this approach; on the other hand, if it actually does somethign because of a mismatch between getWifiState and isWifiOn, I'd much, much, much rather fix NetworkManager instead ;)). |
I wouldn't mind a comment on that one, too; but I'm fine with this approach (even if I'm still not quite sure what's happenign here, and if it isn't very very very timing-specific to your setup...). |
Let us wait with this one too. |
I assume the idea is to prevent entering suspend right when we stop blocking from the WiFi stuff (which would probably fail, even if there were no weird display stuff entering the mix), which certainly makes sense on paper ;). |
This opens up another can of worms though: should we take the plunge and hope that our (Not necessarily recommending that, mind you, just a brain dump ;)). |
This commit fixes my problems with the strange screen refresh on turning Wifi on. The root cause is, that Additionally, this solution quasi disables the standby when Wifi is on (by setting a laaarge time for the next sleep; then wie don't have to bother with allow/prevent-standby symmetry). Which simplifies the program flow with Wifi on. |
Makes sense ;o). Now we just have to hope that my Network* events are reliable ;o). |
Ready to merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 2 files at r3, 1 of 1 files at r4, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zwim)
plugins/autosuspend.koplugin/main.lua
line 682 at r4 (raw file):
end --[[ -- not neccessary right now
nit: necessary
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Reviewed 1 of 1 files at r5, all commit messages.
Reviewable status: all files reviewed, 1 unresolved discussion (waiting on @zwim)
lgtm |
This fixes the strange screen refresh (screen is split into four parts, which get refreshed from bottom left clockwise) when toggling Fiwi on (on a Sage).
This change is