Kindle: toggle cover events

[yparitcher]

used on kindle but can be extended to other devices

Allow disabling the hall efect sensor via the sysfs knob, so the kindle system wont sleep & wake the device

for those of use that stay in koreader, are caseless and get spurious wakeups

---

This change is 

[NiLuJe]

I don't quite recall how this works on Kindle, but, FWIW, on Kobo, we essentially get an EV_KEY with a specific keycode, so we can easily ignore the event (and go back to sleep if necessary).

It's handled over here for the UI side:

koreader/frontend/ui/elements/common_settings_menu_table.lua

Lines 213 to 237 in 6c2f230

	if Device:isKobo() then
	common_settings.ignore_sleepcover = {
	text = _("Ignore all sleepcover events"),
	checked_func = function()
	return G_reader_settings:isTrue("ignore_power_sleepcover")
	end,
	callback = function()
	G_reader_settings:toggle("ignore_power_sleepcover")
	G_reader_settings:makeFalse("ignore_open_sleepcover")
	UIManager:askForRestart()
	end
	}
	common_settings.ignore_open_sleepcover = {
	text = _("Ignore sleepcover wakeup events"),
	checked_func = function()
	return G_reader_settings:isTrue("ignore_open_sleepcover")
	end,
	callback = function()
	G_reader_settings:toggle("ignore_open_sleepcover")
	G_reader_settings:makeFalse("ignore_power_sleepcover")
	UIManager:askForRestart()
	end
	}
	end

And sorted somewhere in Device:

koreader/frontend/ui/elements/filemanager_menu_order.lua

Line 59 in 6c2f230

"ignore_sleepcover",

---

TL;DR: Feel free to move the menu entry somewhere around there, too?

[poire-z]

Oh, ok, it's just sleep cover handling ! :)
I guess a menu item "Hall sensor", even with your help_text, is too technical: just name it like the existing menu for handling the sleep cover on Kobo ?
Or better, I guess it should be abstracted low level so the same menu and same bit of code handle like like they do on a Kobo? (unless it's really too different, and we don't have to handle anything at all if it's the Kindle OS that do it all without us even knowing?)

[Frenzie]

We already have code at least in Kobo to deal with spurious wakeups, basically a reasonably quick go back to sleep if no input for a minute (or whatever). As for the menu item I think it should probably just reuse the Kobo "sleepcover event" message; the technical side you'd have to check what the best way is to abstract it away.

[yparitcher]

As usual on kindle we cant get the events, we can only change the sysfs knob to enable / disable on a driver level

[yparitcher]

Kindle also does not advertise as a sleep cover so kindle users might not be familiar with the term. Maybe cover events?

Also i need help with device_spec i am not sure how to convert its expecting us to use os.execute when we don't use it anymore

[Frenzie]

I think that maps fairly cleanly to "ignore all sleepcover events"? :-)

[Frenzie]

Kindle also does not advertise as a sleep cover so kindle users might not be familiar with the term. Maybe cover events?

What term does Kindle use?

[yparitcher]

Kindle also does not advertise as a sleep cover so kindle users might not be familiar with the term. Maybe cover events?

What term does Kindle use?

Kindle {model} cover

Deep in product details it says wakes and sleeps kindle

[NiLuJe]

Random fun fact: I seem to recall that (on the PW5, at least) there's actually (at least?) two of them, one calibrated for the back, and one for the front. This is (I imagine) to help deal with tolerance issues to prevent false-positives from the back (when there's an actual cover involved, at least).

I don't recall how/where/why I even checked that, because I've never used a cover with a Kindle, but I remember thinking that it the implementation looked neat (especially given the amount of crap false positives like that have caused on kobo ;p).

[hius07]

"The Hall-effect principle is named for physicist Edwin Hall. In 1879 he discovered that when a conductor or semiconductor with current flowing in one direction was introduced perpendicular to a magnetic field a voltage could be measured at right angles to the current path."
May be capitilize "hall"?

[Frenzie]

Incidentally, I've been considering buying a Gulikit KingKong 2, with Hall effect sensors.

But over here as I said I'm not sure how much sense it makes to talk about the underlying tech instead of what it does (i.e., detect covers).

[poire-z]

Also, I understand that the Kindle has it enabled by default ? And that you added that option to allow disabling it because it sucks ?
Then I would just name it [ ] Disable cover events (or [ ] Disable Kindle cover events if it's really clear to all it's Kindle system stuff outside of us).

[hius07]

I meant the capitalization only.

[yparitcher]

Random fun fact: I seem to recall that (on the PW5, at least) there's actually (at least?) two of them, one calibrated for the back, and one for the front. This is (I imagine) to help deal with tolerance issues to prevent false-positives from the back (when there's an actual cover involved, at least).

I don't recall how/where/why I even checked that, because I've never used a cover with a Kindle, but I remember thinking that it the implementation looked neat (especially given the amount of crap false positives like that have caused on kobo ;p).

Makes sense, as it is more difficult to trigger this on my pw5 then on older models

[yparitcher]

Ready to merge

[poire-z]

Fine with the final wording. (Haven't looked at the lower level stuff.)

[Frenzie]

lgtm, left a small phrasing nit