[fix] Reintroduce "Start with" default to prevent nil string on startup #10369
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Regression from koreader#10198. Fixes koreader#10368.
NiLuJe
reviewed
Apr 29, 2023
| @@ -889,7 +889,7 @@ function FileManagerMenu:getStartWithMenuTable() | |||
| end | |||
| return { | |||
| text_func = function() | |||
| local start_with = G_reader_settings:readSetting("start_with") | |||
| local start_with = G_reader_settings:readSetting("start_with") or "filemanager" | |||
There was a problem hiding this comment.
I was going to say G_reader_settings:readSetting("start_with", "filemanager") is also an option now, but since we don't actually do anything write-related to the settings here, this is probably still clearer.
NiLuJe
approved these changes
Apr 29, 2023
hius07
approved these changes
Apr 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Regression from #10198.
Fixes #10368.
This change is