Skip to content

Dispatcher: add addCurrentLocationToStack #10387

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
May 5, 2023

Conversation

yparitcher
Copy link
Member

@yparitcher yparitcher commented May 4, 2023

This is useful when i want to reference something a few pages away while keeping track of my current page


This change is Reviewable

@yparitcher yparitcher added this to the 2023.05 milestone May 4, 2023
@poire-z
Copy link
Contributor

poire-z commented May 4, 2023

May be add a notification so you're sure you didn't fail your gesture ? :) as in 7bae2ed

And the day you are bored (noticed that in #10370):

Note: in dispatcher.lua, the action definitions (with separators) and the ordering are in 2 different lists, and their ordering is different, which makes it tedious to properly update and figuring out where to insert/update separators.

yparitcher added 2 commits May 4, 2023 19:04
This is useful when i want to reference something a few pages away while keeping track of my current page
@yparitcher
Copy link
Member Author

yparitcher commented May 5, 2023

Added a notification.

Reorded the dispatcher items, with the exception that the items parsed from CreOptions and KoptOptions are grouped separately.

Ready on my end

Copy link
Contributor

@poire-z poire-z left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the list reordering :)

@Frenzie Frenzie merged commit b18ab63 into koreader:master May 5, 2023
@yparitcher yparitcher deleted the loc_stack branch May 5, 2023 13:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants