mac: github actions macos-13

[yparitcher]

github no longer supports 10.15 so lets see if 13 works

@JasonInOttawa Can you please test?

If this doesn't work then i will disable the workflow for now.

---

This change is 

[Frenzie]

I think having some guard against breaking the macOS build would still provide added value even if the generated artifact is useless, though on the flip side I've learned to completely ignore it because half the time it doesn't succeed for various reasons.

[JasonInOttawa]

I tried downloading the artifact and it crashes on startup:

% ./KOReader.app/Contents/MacOS/koreader 
---------------------------------------------
                launching...
  _  _____  ____                _
 | |/ / _ \|  _ \ ___  __ _  __| | ___ _ __
 | ' / | | | |_) / _ \/ _` |/ _` |/ _ \ '__|
 | . \ |_| |  _ <  __/ (_| | (_| |  __/ |
 |_|\_\___/|_| \_\___|\__,_|\__,_|\___|_|

 It's a scroll... It's a codex... It's KOReader!

 [*] Current time: 05/08/23-12:23:28
 [*] Version: v2023.04-28-gee6bbd79_2023-05-08

ffi.load: libs/libutf8proc.2.dylib
ffi.load: blitbuffer
ffi.load (assisted searchpath): ./libs/libblitbuffer.so
ffi.load: libs/libSDL2.dylib
ffi.load: SDL2
Starting SDL in /Users/jason/Downloads/KOReader.app/
SDL: no gamecontrollers connected
ffi.load: libs/liblodepng.dylib
05/08/23-12:23:29 INFO  initializing for device Mac OS X 
05/08/23-12:23:29 INFO  framebuffer resolution: {
  h = 1694,
  w = 1680
} --[[table: 0x008e34d0]] 
ffi.load: libs/libmupdf.dylib
ffi.load (warning): dlopen(libs/libmupdf.dylib, 0x0005): Library not loaded: @rpath/libsharpyuv.0.dylib
  Referenced from: <2D153D51-0E0A-3280-8B83-D96F3C48024F> /Users/jason/Downloads/KOReader.app/Contents/koreader/libs/libwebp.7.dylib
  Reason: tried: '/Users/jason/Downloads/KOReader.app/Contents/koreader/libs/../lib/libsharpyuv.0.dylib' (no such file), '$ORIGIN/libsharpyuv.0.dylib' (no such file), '$ORIGIN/libsharpyuv.0.dylib' (no such file), '/usr/local/lib/libsharpyuv.0.dylib' (no such file), '/usr/lib/libsharpyuv.0.dylib' (no such file, not in dyld cache)
failed to run lua chunk: ./setupkoenv.lua:27: Not able to load dynamic library: libs/libmupdf.dylib

[yparitcher]

Libsharpyuv is now a dependency of libwebp so this needs to be updated:

koreader/platform/mac/do_mac_bundle.sh

Line 149 in ea3fa5c

cp "${BREW}/gettext/lib/libintl.8.dylib" "${BREW}/webp/lib/libwebp.7.dylib" "${BREW}/libsodium/lib/libsodium.23.dylib" libs

[yparitcher]

@JasonInOttawa
Please try now

[benoit-pierre]

Why is the libwebp provided by base/thirdparty not being used?

[JasonInOttawa]

I tried the artifact. It launches but books crash on open. Attached are the problem report and koreader crash log.

On my Macbook, I have to do a debug build to avoid the crash on book open.

problem.txt
crash.log

[NiLuJe]

Why is the libwebp provided by base/thirdparty not being used?

Good question ;o).

I assume because the bundle script predates us actually building libwebp, but I haven't checked ;).

[Frenzie]

libwebp wasn't used prior to us building it so I don't think that makes much sense as a hypothesis. :-P

[NiLuJe]

I simply meant that the bundle script predates our own shared webp by about 2 years ;).

[yparitcher]

Ready for merge?

[Frenzie]

Sure, merge if you think it's done.