Exporter: add memos export #10411
Exporter: add memos export #10411
Conversation
| buttons = { | ||
| { | ||
| { | ||
| text = _("Cancel"), |
There was a problem hiding this comment.
Can you add id = "close" to enable exiting the dialog on non-touch devices.
There was a problem hiding this comment.
I am not familiar with lua and koreader, this is what I changed according to the code of other export plugins, now please see if there is any problem with my modification, thank you.
plugins/exporter.koplugin/main.lua
Outdated
| @@ -38,7 +38,7 @@ local _ = require("gettext") | |||
|
|
|||
| -- migrate settings from old "evernote.koplugin" or from previous (monolithic) "exporter.koplugin" | |||
| local function migrateSettings() | |||
| local formats = { "html", "joplin", "json", "readwise", "text", "my_clippings" } | |||
| local formats = { "html", "joplin", "json", "readwise", "text", "my_clippings", "memos" } | |||
There was a problem hiding this comment.
It used to be sorted.
Could you please sort it again (both memos and my_clippings). Thanks!
There was a problem hiding this comment.
Is that the correct ordering: 'html', 'joplin', 'json', 'memos', 'my_clippings', 'readwise', 'text' ?
hius07
changed the title
|
Looks good (didn't tested the memos service). |
|
@hius07 Do I need to add tests to the code. I tested it myself and it works. Do I need to provide screenshots or something like that? |
Good, it's enough I think. |
|
Anyone got this working? As I've tried 2024.3.1/.3/.1 and 2023.10 - no luck although API works with curl and android memos app locally and via FQDN, flomo has same issue too - exporter says successful but no data retrieved in apps. Also once I manually specify memos via share option I got crash every time no matter what.
|
|
@cpuks sorry it's been a busy time, can you tell me the version of memos you are currently using, I'll test it out |
Add an export method for memos, which originates from flomo and now has an open-source self-deployment solution:memos
This change is