Dict/Wiki results: add button to show list of results #10424
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
By providing the font that will be used. As it's more expensive, use only when really needed.
The final height of a button could be different whether a smaller font size or multiline end up being used. Also fix 2-lines logical error making it less favored. Also forward any lang property to the underlying text widgets.
When the containee is row-based, this can ensure that when scrolling with swipes, we get the a full row at top, and that any truncated row at top or bottom is fully visible after a swipe.
With tall ButtonDialog with many rows, allows for a more natural and readable scrolling without any truncated row (like in Excel, we previously behave as web browsers). ButtonTable: - make the span and separator layout more explicite - add some small horizontal padding when button text is centered
Add a left button to the title bar to show the list of results as a popup. Dictionary: tap or long-press on that button give different view of the results. Wikipedia: request 30 results instead of 20, so we can show 15, 10 or 6 of them per page of that popup.
Frenzie
approved these changes
May 11, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed all along #10304. Closes #10304.
TextBoxWidget:getFontSizeToFitHeight(): allow for more accuracy
By providing the font that will be used. As it's more expensive, use only when really needed.
Button: fix unstable height
The final height of a button could be different whether a smaller font size or multiline end up being used.
Also fix 2-lines logical error making it less favored.
Also forward any lang property to the underlying text widgets.
ScrollableContainer: add support for step/grid scrolling
When the containee is row-based, this can ensure that when scrolling with swipes, we get the a full row at top, and that any truncated row at top or bottom is fully visible after a swipe.
ButtonDialog: allow for step/page scrolling
With tall ButtonDialog with many rows, allows for a more natural and readable scrolling without any truncated row (like in Excel, we previously behave as web browsers).
ButtonTable:
DictQuickLookup: add button to show list of results
Add a left button to the title bar to show the list of results as a popup.
Dictionary: tap or long-press on that button give different view of the results.
Wikipedia: request 30 results instead of 20, so we can show 15, 10 or 6 of them per page of that popup
This change is