Exporter: selected files #10453
Merged
Exporter: selected files #10453
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Frenzie
reviewed
May 18, 2023
plugins/exporter.koplugin/main.lua
Outdated
| @@ -171,6 +171,18 @@ function Exporter:exportAllNotes() | |||
| self:exportClippings(clippings) | |||
| end | |||
|
|
|||
| function Exporter:exportFilesNotes(files) | |||
| -- @table files {[file_path] = true} | |||
There was a problem hiding this comment.
The comment is intended to explain the type/structure of the argument.
There was a problem hiding this comment.
I'd prefer if you made it a regular ldoc comment above the definition. People copy things. ;-)
Frenzie
approved these changes
May 18, 2023
|
I don't have time to look into it atm but just leaving a note that that last commit seems to have made the docs unhappy. :-) |
|
Don't know exactly what breaks the docs; koreader/plugins/exporter.koplugin/main.lua Lines 176 to 178 in 3d57752 Maybe brackets? |
|
Possibly, try to put that section between |
|
If anybody should wonder in the future, fixed in #10465 |
|
Thanks! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Export highlights for selected files.
Having a button "Select all files in folder", it is easy to export the whole folder.
So, closes #10402.
To keep even number of buttons, added a feature "Show selected files list". May be useful to check selections before an operation. Just a sorted list, no titlebar or popup menu, tapping a file jumps to its folder.
This change is