Skip to content

Wikipedia EPUBs: strip out invalid-XHTML <link> #10462

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 19, 2023
Merged

Wikipedia EPUBs: strip out invalid-XHTML <link> #10462

merged 1 commit into from
May 19, 2023

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented May 19, 2023 •
edited by Frenzie
Loading

See #10459 (comment).
Closes #10459.

This change is Reviewable

@poire-z poire-z added this to the 2023.05 milestone May 19, 2023
Frenzie
Frenzie approved these changes May 19, 2023
View reviewed changes
Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we use 'em for anything regardless, do we? 👍

@poire-z
Copy link
Contributor Author

poire-z commented May 19, 2023

No, we just add our own <link type="text/css" rel="stylesheet" href="stylesheet.css"/> outside their HTML - and I don't think anything in crengine uses <link> for anything but those inside <head> containing stylesheets.

@poire-z poire-z merged commit 011c168 into koreader:master May 19, 2023
@poire-z poire-z deleted the wikipedia_strip_out_link branch May 19, 2023 14:48
@poire-z poire-z mentioned this pull request Jun 2, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Frenzie Frenzie Frenzie approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
2023.05
Development

Successfully merging this pull request may close these issues.

Wikipedia ePubs are unreadable
2 participants
@poire-z @Frenzie