BookMap: visual tweaks and enhancements #10530
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also fix possibly unbalanced left and right margins.
Align page numbers (the vertical ones, on the left of a BookMapRow) on the baseline of the BookMapRow, where page slots rise from. Also tweak the page number spike below the baseline used in PageBrowser.
Enabled by default, to get the current behaviour. Disabling it allows people with small fingers to jump directly to that page in Reader.
Allows hairy-boxes amateurs to get small markers (under the baseline) every 10 pages (with -/+ to get small or medium markers, with optionally smaller ones every 5 pages).
Add a restricted but convenient mode showing BookMap like in initial view, while still allowing chapter levels to be tweaked. This allows getting back to this view with another gesture to see the overall progress in the book, while still having the normal BookMap in flat mode acting as an alternative ToC. Available as an action to associate to a gesture, and with long-press on the "Book map" menu item.
poire-z
commented
Jun 4, 2023
| }) | ||
| if self.overview_mode then | ||
| text = text .. "\n\n" .. _([[ | ||
| In overview mode, the book map is always in grid mode and ensured to fit on a single screen. Chapter levels can be changed for the most confortable overview.]]) |
There was a problem hiding this comment.
@Frenzie : no comment about this added sentence wording ?
(The rest is just splitted previous text :/ for reuse in the 2 cases.)
There was a problem hiding this comment.
Actually I hadn't noticed that there was some added. There's a French typo in comfortable.
And maybe "made to fit" would sound a touch better than "ensured to fit"?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Discussed all along #10433. Closes #10433.
PageBrowser: smaller margins if no thumbnail page numbers
Also fix possibly unbalanced left and right margins.
BookMap: nicer alignment of the vertical page number
Align page numbers (the vertical ones, on the left of a BookMapRow) on the baseline of the BookMapRow, where page slots rise from.
Also tweak the page number spike below the baseline used in PageBrowser.
BookMap: add option "Page browser on tap"
Enabled by default, to get the current behaviour.
Disabling it allows people with small fingers to jump directly to that page in Reader.
BookMap: add option "10-page markers"
Allows hairy-boxes amateurs to get small markers (under the baseline) every 10 pages (with -/+ to get small or medium markers, with optionally smaller ones every 5 pages).
BookMap: add "Overview" mode
Add a restricted but convenient mode showing BookMap like in initial view, while still allowing chapter levels to be tweaked. This allows getting back to this view with another gesture to see the overall progress in the book, while still having the normal BookMap in flat mode acting as an alternative ToC.
Available as an action to associate to a gesture, and with long-press on the "Book map" menu item.
This change is