BookMap: fix help text wording #10544
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
A bit hard to tell. It seems to have been broken since #10492. |
What "it" ? |
|
Not Weblate, but that PR broke the tests and the underlying assumption I
put in there is that we don't want to bother translators with something
that may be reverted because it's broken.
…On Mon, Jun 5, 2023, 17:01 poire-z ***@***.***> wrote:
A bit hard to tell. It seems to have been broken
What "it" ?
Weblate and our translations abilities are broken?
—
Reply to this email directly, view it on GitHub
<#10544 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AABRQBJCZWXXPC5WODNJRITXJXYGPANCNFSM6AAAAAAY2UMQD4>
.
You are receiving this because you were mentioned.Message ID:
***@***.***>
|
|
Not really following you :/ |
|
https://github.com/koreader/koreader/runs/13993281963 fails, so docs and translation are blocked from running. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See #10530 (comment).
@Frenzie: please have a look at the new strings appearing in weblate, that I didn't miss/mess anything else :)
This change is