Skip to content

[AutoWarmth] Fix resume and frontlight issue #10557

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 9, 2023
Merged

[AutoWarmth] Fix resume and frontlight issue #10557

merged 1 commit into from
Jun 9, 2023

Conversation

zwim
Copy link
Contributor

@zwim zwim commented Jun 9, 2023 •
edited by Frenzie
Loading

Fixes a regression introduced in #10426, when suspending during night and resuming during daylight.

see

koreader/frontend/device/kobo/powerd.lua

Line 450 in fc71814

UIManager:scheduleIn(0.001, self.turnOnFrontlight, self)

This change is Reviewable

@zwim zwim added the Plugin label Jun 9, 2023
@zwim zwim added this to the 2023.06 milestone Jun 9, 2023
@zwim zwim requested review from Frenzie, NiLuJe, pazos and poire-z as code owners June 9, 2023 13:20
NiLuJe
NiLuJe approved these changes Jun 9, 2023
View reviewed changes
Copy link
Member

@NiLuJe NiLuJe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Matches how this is done in turnOffFrontlightHW, LGTM ;).

@Frenzie Frenzie merged commit 1ce1fe1 into koreader:master Jun 9, 2023
@zwim zwim deleted the fixAutoWarmthResume branch June 10, 2023 19:52
@zwim zwim mentioned this pull request Jun 12, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@NiLuJe NiLuJe NiLuJe approved these changes

@Frenzie Frenzie Awaiting requested review from Frenzie Frenzie is a code owner

@pazos pazos Awaiting requested review from pazos pazos is a code owner

@poire-z poire-z Awaiting requested review from poire-z poire-z is a code owner

Assignees
No one assigned
Labels
Plugin
Projects
None yet
Milestone
2023.06
Development

Successfully merging this pull request may close these issues.
3 participants
@zwim @NiLuJe @Frenzie