-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Archive viewer #10584
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Archive viewer #10584
Conversation
plugins/arcviewer.koplugin/main.lua
Outdated
end | ||
end | ||
|
||
local std_out = io.popen("unzip ".."-qql \""..file.."\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we do that on Android?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Taken from
koreader/frontend/document/credocument.lua
Lines 74 to 75 in 64f778d
function CreDocument:zipContentExt(fname) | |
local std_out = io.popen("unzip ".."-qql \""..fname.."\"") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm but either improve the description or leave it out ;-)
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
plugins/arcviewer.koplugin/main.lua
Outdated
function ArcViewer:extractFile(arcfile, filepath) | ||
UIManager:show(ConfirmBox:new{ | ||
text = _("Extract this file?") .. "\n\n" .. filepath .. "\n\n" .. | ||
_("If the file already exists, it will be overwritten."), | ||
ok_text = _("Extract"), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This plugins only extract files ? and we then have to exit it and go browse to the extraction location to then view the file ?
It is a bit lying to its name :) I would be expecting to view an image in ImageViewer, and any other stuff in TextViewer.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, I'm going to extend the plugin functionality later.
Upgraded KOReader today - tried this plugin, but it always shows me "no items" (even on really simple epub filenames without any space or problematic chars). |
Does |
unzip is found, and replies. But may be not in the format you expect. The output of my debian unzip (UnZip 6.00 of 20 April 2009, by Debian) on the emulator:
And on my Kobo:
Your |
Sometimes I am curious about the archive content.
Zip (epub, cbz) only so far.
This change is