QuickMenu: add long-press on profile

[hius07]

Fixes #10668 (comment).

Long-press on a profile entry in a QuickMenu calls a new QM with the content of the profile and "Execute all" button.

---

This change is 

[poire-z]

@yparitcher : ok for you?

[yparitcher]

@hius07

I thought to do it slightly differently in yparitcher@4d0578d
This will leave the signature of Dispatcher:execute the way it is without adding any new arguments.

What are your thoughts? (I dont intend to rewrite all you dispatcher PRs, i just like keeping the function signature clean :)

[hius07]

Can you please clarify what are the benefits?
The code is more complicated, with two tableDeepCopy calls.

[poire-z]

@yparitcher : any followup discussion ?

[yparitcher]

Sorry for the delay,

I thought it would be better not to complicate Dispatcher:execute() with quickmenu details, even if it makes the quickmenu code a little more complicated.

If people think otherwise then that is ok also.

[hius07]

To summarize: the purpose is to "execute" a profile overriding its show_as_quickmenu setting, i.e. to forcibly run a profile or to show it as a QM.
(1) The initial idea is to add the third argument to Dispatcher:execute(), with options true - show a QM, false - run, nil - honor the profile's show_as_quickmenu setting. (The most of calls will be from other gestures/actions with nil)
(2) Proposed alternative way is to hide the flag into the profile itself. To avoid pollution of the original profile settings, tableDeepCopy is called twice to create temporary profiles.

[poire-z]

I agree with trying to avoid tableDeepCopy.

i just like keeping the function signature clean :)

function Dispatcher:execute(settings, gesture, show_as_quickmenu)
If we change it, and want to keep the function signature not too ugly, may be pass a table, so it's generic enough if we later want to add other behaviour tweaks ?

function Dispatcher:execute(settings, gesture, exec_tweaks)
exec_tweaks = { show_as_quickmenu = false }
(exec_tweaks or overrides or params or a better name by better english talking people :)

[Frenzie]

Something like overrides seems clearer unless I misunderstand the intent.

[hius07]

function Dispatcher:execute(settings, gesture, exec_tweaks)
The full gesture table is not used, we need a gesture position for QM anchoring only, so we can hide the flag anchor_quickmenu = ges.pos into the exec_tweaks table.

[hius07]

Update: dispatcher execution is managed via the container (table) exec_props.
Currently has two properties:
qm_show: forcibly show QM / run
qm_anchor: quick menu anchoring

[hius07]

Not good, I've missed some events get gesture as an argument.

[hius07]

So, 3 arguments to Dispatcher:execute.

[poire-z]

Missing a nil or false "gesture" as the 2nd argument ?
(I guess it would look odd if we put "gesture" inside the exec_props table ?)

[hius07]

(I guess it would look odd if we put "gesture" inside the exec_props table ?

I think it'll simplify a little bit.
@yparitcher can you please review.

[yparitcher]

LGTM

You can merge the gesture argument if you want, but you don't have to.

[hius07]

Shouldn't we use elseif when checking the category in Dispatcher:execute()?

[poire-z]

On line now 1084? I Looks like we could.

[hius07]

And further, there are two more checks.

[yparitcher]

This conditional is a bit long and confusing to read, bur not sure of any way that is better

[mergen3107]

Thank you very much @hius07 !
This PR works great on -44!

[mergen3107]

Only thing missing is that Font name change doesn’t have notification, but I think this is because usually fonts are select in the top menu, while they are all visible :D