Style tweaks: notification on toggling style tweak with a gesture #10674
Conversation
| @@ -726,6 +727,7 @@ function ReaderStyleTweak:onToggleStyleTweak(tweak_id, item) | |||
| else | |||
| self.doc_tweaks[tweak_id] = nil | |||
| end | |||
| text = _("Disabled style tweak: ") | |||
There was a problem hiding this comment.
@Frenzie will confirm if there is a risk having translatable strings ending with a space - and translator missing it in their translation.
(These notifications will probably be long and end up truncated.)
There was a problem hiding this comment.
Yes, at a glance it'd be better to use the template function right here and in the else with %1 and self.tweaks_in_dispatcher[tweak_id] as an argument.
| @@ -727,7 +727,7 @@ function ReaderStyleTweak:onToggleStyleTweak(tweak_id, item, no_notification) | |||
| else | |||
| self.doc_tweaks[tweak_id] = nil | |||
| end | |||
| text = _("Disabled style tweak: ") | |||
| text = T(_("Off: %1"), self.tweaks_in_dispatcher[tweak_id]) | |||
There was a problem hiding this comment.
I guess that for such short and standard On/Off:, we should add some translation context and/or a @ translator comment.
There was a problem hiding this comment.
Can we just make these notifications always in two lines? First line is “Style tweak enabled/disabled:” in any language, second line is the css name.
There was a problem hiding this comment.
Currently notification is a TextWidget
There was a problem hiding this comment.
Yes, I have thought about having it multilines in the past, but gave up. We don't really need it to be more than one line, we're mostly fine elsewhere - and most people don't care about notifications, so the smaller the better :)
There was a problem hiding this comment.
I do think it's a good suggestion all around. Concatenating .. "\n" .. (or maybe two) bothers translators the minimum amount and the display would likely be better too. Except for that single line notification aspect. :-)
There was a problem hiding this comment.
But yes, also notifications should be as small as possible, forgot about that for a second.
|
Stack Overflow on GitHub? That’s something new :D |
|
Thank you @hius07 ! Otherwise works great and now I have a visual confirmation :D |
Closes #10667.
This change is