Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump LunaSVG, crengine: add support for .docm #10702

Merged
merged 1 commit into from
Jul 16, 2023

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented Jul 16, 2023

Includes:

crengine koreader/crengine#523 :

  • DocX: add support for similar DocM format - Closes FR: Open .docm files #10599.
  • LVStyleSheet: fix LVCssDeclaration::getHash()
  • CSS parsing: accept Unicode values for ID and classnames
  • update for Harfbuzz 8, fix some compiler warning

Also fix input not restored when loading failed, and KOReader not able to exit (showing an InfoMessage "KOReader will exit not." and waiting for a dismiss tap - which did never happen as input was not restored :)


This change is Reviewable

Includes:
- bump LunaSVG: intermediate upstream bump, cleanup
- bump LunaSVG: minor upstream tweaks
crengine:
- DocX: add support for similar DocM format
- LVStyleSheet: fix LVCssDeclaration::getHash()
- CSS parsing: accept Unicode values for ID and classnames
- update for Harfbuzz 8, fix some compiler warning

Also fix input not restored when loading failed,
and KOReader not able to exit.
@poire-z poire-z added this to the 2023.07 milestone Jul 16, 2023
@@ -1509,6 +1509,7 @@ function CreDocument:register(registry)
registry:addProvider("chm", "application/vnd.ms-htmlhelp", self, 90)
registry:addProvider("doc", "application/msword", self, 90)
registry:addProvider("docx", "application/vnd.openxmlformats-officedocument.wordprocessingml.document", self, 90)
registry:addProvider("docm", "application/vnd.ms-word.document.macroEnabled.12", self, 90)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One could say that's a quality... memetype. kaching!

@poire-z poire-z merged commit 8a240dd into koreader:master Jul 16, 2023
@poire-z poire-z deleted the bump_luna_cre branch July 16, 2023 17:18
@poire-z poire-z mentioned this pull request Jul 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FR: Open .docm files
3 participants