-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Update Greek keyboard #10734
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Greek keyboard #10734
Conversation
No update to el_popup.lua, or you forgot to add it ? For the greek side of checks, pinging @noembryo. |
I've done it, but I didn't manage to add it to this one. How can it been done? I made a separate PR. |
Not using github web. |
Just go to |
Thank you. Should I do it now and delete the other PR or this is for another time? |
Done! |
Thank you for your check. Regarding the letters with accents, yes, it makes sense with Greek to follow the direction of the accents, and that's what I did when I first arranged the poppups to meet the needs of polytonic Greek. But in use, I found that it was more convenient to have the letter with the acute accent (tonos) on the right key, as it's a short gesture that we can make without waiting for the popup to open. After all, it's the only accent mark used in the monotonic Greek , which is mostly used today. So I've put the letters with grave and acute accent in the left and right popup keys respectively and the letters with breathings (which are used in the polytonic Greek) in the north left and north right popup keys. In the rest keys I've put some other combinations. However there are more combinations possible that can be made with the help of the combinations characters that can be found in the number 6 popup. In the dot popup I've added the upper dot and the middle dot. I've also put the upper dot, which is used in Greek, in the W key (the Greek ς key). Where you read "polytonic Greek" you can understand ancient Greek, but this is not absolute, since the breathings and various tones are used even with modern Greek by some. |
Ok, thanks. Glad there is some thoughts and consistency behind all that :) I was initially a bit bothered that the comma key was put on the right edge, as it has many CSS related stuff where I do use swipe right to output The dot key is also similarly used for 'regular expression' characters. So, you're allowed to get rid of all the odd chars in the dot and the comma popups, and put there any punctuation that makes more sense for your language.
In the English and most other keyboards, the north key is usually the uppercase variant of that key (and on the uppercase keyboard, the lowercase variant): it allows easily starting a word uppercase with a swipe north, without having to switch layouts. |
At one point I considered not including the English characters at all. Then I saw that there was room on most keys, so I included them. However, as you say, I think it's more convenient to switch to the English keyboard to use English characters, just as with the physical keyboard. In Greek we use the upper dot (· = ano teleia) like the semicolon in English (;). The use the sign of English semicolon as a question mark :-). I've also put the middle dot because sometimes there are text that may have used the middle dot as an upper dot. The problem is that there is no difference as they appear in the popup.
The truth is that I hadn't noticed that. Of course, sentences in Greek also start with an uppercase letter. So I'll follow your suggestion. The only problem is that there will be no free keys for some polytonic combinations in some popup keys of vowel letters. But I think I might be the only Greek user of KOReader who uses polytonic Greek for text search... So it's more important to support monotonic Greek and let the polytonic combinations be done with the help of the combinations characters that can be found in the number 6 popup, now that they have been normalised. |
Great, that's the start of learning Greek. :-) Let me add that I have put in the popup of letter "ς" some Greek numeral symbols. They are useful when one wants to write a number with Greek letters. Edit: I put archaic "koppa" (Ϙ) in popup of ";" (that is the letter Q in English keyboard) because it is seams like Q, as it is its ancestor. |
Even those of us who don't learn Greek all learn Greek letters and counting in physics and chemistry. xD Edit: and of course you have sigma and delta and stuff in math but that's not quite as extensive. |
Of course as the Latin alphabet is mostly derived from the Greek alphabet... ;-) |
Update the Greek keyboard to the new keyboard layout.
This change is