Skip to content

Update Greek keyboard #10734

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
Aug 1, 2023
Merged

Update Greek keyboard #10734

merged 4 commits into from
Aug 1, 2023

Conversation

ichnilatis-gr
Copy link
Contributor

@ichnilatis-gr ichnilatis-gr commented Jul 23, 2023

Update the Greek keyboard to the new keyboard layout.


This change is Reviewable

@poire-z
Copy link
Contributor

poire-z commented Jul 23, 2023

No update to el_popup.lua, or you forgot to add it ?

For the greek side of checks, pinging @noembryo.

@ichnilatis-gr
Copy link
Contributor Author

ichnilatis-gr commented Jul 23, 2023

No update to el_popup.lua, or you forgot to add it ?

I've done it, but I didn't manage to add it to this one. How can it been done? I made a separate PR.

@poire-z
Copy link
Contributor

poire-z commented Jul 23, 2023

Not using github web.
Pinging @hius07 for advices if there's a trick adding other files.

@hius07
Copy link
Member

hius07 commented Jul 23, 2023

Just go to
https://github.com/ichnilatis-gr/koreader/tree/patch-2
choose another file and press the Pen button to edit it.
And then the green "Commit" button.

@ichnilatis-gr
Copy link
Contributor Author

Thank you. Should I do it now and delete the other PR or this is for another time?

@ichnilatis-gr
Copy link
Contributor Author

Done!

@ichnilatis-gr ichnilatis-gr changed the title Update el_keyboard.lua Update Greek keyboard Jul 23, 2023
@Frenzie Frenzie added this to the 2023.07 milestone Jul 23, 2023
@poire-z
Copy link
Contributor

poire-z commented Jul 28, 2023

I just had a quick check before merging - no problem noticed.

I'm not that familiar with Greek letters, but looking at the popups on the lowercase letters, I see that there are often a latin letter equivalent to that greek letter, in the popup north west key - but not always, sometimes it's the north key. Any reason ?

image
image image
but:
image image image image

Any other specific rules you had in mind and followed when making that keyboard ?
(ie. we have one on the EN or FR keyboard that é and è are such that your finger swipe gesture has to follow the accent direction image :) Dunno if that makes sense with Greek.

If yes, please detail them here, so our 3 or 4 other Greek users can know them and figure out why your layout is at it is :)

@ichnilatis-gr
Copy link
Contributor Author

ichnilatis-gr commented Jul 28, 2023

Thank you for your check.
Regarding the Latin letters in popups, I put them to correspond to the English keyboard where there are Greek letters in popups. And, to be honest, I didn't always make sure that I put them in the same position, which is also true for the Greek letters in the English keyboard.
As you might have guessed, I also like consistency, so I will put all the English letters in the popup north key.

Regarding the letters with accents, yes, it makes sense with Greek to follow the direction of the accents, and that's what I did when I first arranged the poppups to meet the needs of polytonic Greek. But in use, I found that it was more convenient to have the letter with the acute accent (tonos) on the right key, as it's a short gesture that we can make without waiting for the popup to open. After all, it's the only accent mark used in the monotonic Greek , which is mostly used today. So I've put the letters with grave and acute accent in the left and right popup keys respectively and the letters with breathings (which are used in the polytonic Greek) in the north left and north right popup keys. In the rest keys I've put some other combinations. However there are more combinations possible that can be made with the help of the combinations characters that can be found in the number 6 popup.
Where I've used all the popup keys with the combinations for polytonic Greek, I've put the Latin letters of that key in the Greek letter χ popup, as is done for the Greek letters on the English keyboard.

In the dot popup I've added the upper dot and the middle dot. I've also put the upper dot, which is used in Greek, in the W key (the Greek ς key).

Where you read "polytonic Greek" you can understand ancient Greek, but this is not absolute, since the breathings and various tones are used even with modern Greek by some.

@poire-z
Copy link
Contributor

poire-z commented Jul 28, 2023

Ok, thanks. Glad there is some thoughts and consistency behind all that :)

I was initially a bit bothered that the comma key was put on the right edge, as it has many CSS related stuff where I do use swipe right to output !important, which would not be possible then.
But, it is also similarly inconveniently placed on the Russian keyboard, and absent on the Ukrainian keyboard - so I guess it does not matter for non-English keyboards: someone outputing CSS (for manual style tweaks) would have to switch to the English keyboard anyway to output easily english letters (for HTML element and class names, CSS properties & values).

The dot key is also similarly used for 'regular expression' characters.

So, you're allowed to get rid of all the odd chars in the dot and the comma popups, and put there any punctuation that makes more sense for your language.

As you might have guessed, I also like consistency, so I will put all the English letters in the popup north key.

In the English and most other keyboards, the north key is usually the uppercase variant of that key (and on the uppercase keyboard, the lowercase variant): it allows easily starting a word uppercase with a swipe north, without having to switch layouts.
So, if Greek also starts sentences with an uppercase (does it ? :) , you could follow that rule, and put the latin/english letter as north-east or north-west.

@ichnilatis-gr
Copy link
Contributor Author

ichnilatis-gr commented Jul 29, 2023

So, you're allowed to get rid of all the odd chars in the dot and the comma popups, and put there any punctuation that makes more sense for your language.

At one point I considered not including the English characters at all. Then I saw that there was room on most keys, so I included them. However, as you say, I think it's more convenient to switch to the English keyboard to use English characters, just as with the physical keyboard.

In Greek we use the upper dot (· = ano teleia) like the semicolon in English (;). The use the sign of English semicolon as a question mark :-). I've also put the middle dot because sometimes there are text that may have used the middle dot as an upper dot. The problem is that there is no difference as they appear in the popup.

In the English and most other keyboards, the north key is usually the uppercase variant of that key (and on the uppercase keyboard, the lowercase variant): it allows easily starting a word uppercase with a swipe north, without having to switch layouts.
So, if Greek also starts sentences with an uppercase (does it ? :) , you could follow that rule, and put the latin/english letter as north-east or north-west.

The truth is that I hadn't noticed that. Of course, sentences in Greek also start with an uppercase letter. So I'll follow your suggestion. The only problem is that there will be no free keys for some polytonic combinations in some popup keys of vowel letters. But I think I might be the only Greek user of KOReader who uses polytonic Greek for text search... So it's more important to support monotonic Greek and let the polytonic combinations be done with the help of the combinations characters that can be found in the number 6 popup, now that they have been normalised.

@poire-z
Copy link
Contributor

poire-z commented Jul 30, 2023

I already have a hard time trying to read (just to pronounce words and try to guess the meaning) lowercase greek letters, and I realized that I don't even know the uppercase letters (except for Omega and Sigma that I've seen in math class :)
Was surprised to see that many of them look more like our Latin/English uppercase, so I wondered if you messed up :/ But no, Google/Wikipedia confirms you seem to have it right:
image

So, the spirit of the popups looks ok to me :)

@ichnilatis-gr
Copy link
Contributor Author

ichnilatis-gr commented Jul 31, 2023

Great, that's the start of learning Greek. :-)

Let me add that I have put in the popup of letter "ς" some Greek numeral symbols. They are useful when one wants to write a number with Greek letters.
These are some mostly archaic letters, such as "digamma" (Ϝ) and "stigma" (ϛ) for 6, "koppa" (Ϙ or ϟ) for 90 and "sampi" (ϡ) for 900.

Edit: I put archaic "koppa" (Ϙ) in popup of ";" (that is the letter Q in English keyboard) because it is seams like Q, as it is its ancestor.

@Frenzie
Copy link
Member

Frenzie commented Jul 31, 2023

Great, that's the start of learning Greek. :-)

Even those of us who don't learn Greek all learn Greek letters and counting in physics and chemistry. xD

Edit: and of course you have sigma and delta and stuff in math but that's not quite as extensive.

@ichnilatis-gr
Copy link
Contributor Author

Was surprised to see that many of them look more like our Latin/English uppercase

Of course as the Latin alphabet is mostly derived from the Greek alphabet... ;-)

@poire-z poire-z merged commit 583ae40 into koreader:master Aug 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants