Skip to content

Kobo: Fix the input translation on the Elipsa 2E #10802

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 12, 2023
Merged

Conversation

NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Aug 11, 2023

Apparently it mirrors on the Y axis. Or the panel vs. touch rotations are wonkier than expected or ...something.

Brain hurty >_<".

Followup to #10719


This change is Reviewable

Apparently it mirrors on the Y axis. Or the panel vs. touch rotations
are wonkier than expected or ...something.

Brain hurty >_<".
@NiLuJe NiLuJe added this to the 2023.08 milestone Aug 11, 2023
@NiLuJe
Copy link
Member Author

NiLuJe commented Aug 11, 2023

Apparently it mirrors on the Y axis

I'd need to check another Elan device tomorrow, but the DTB (... at least the one in the kernel sources, that may not actually match the release, as usual ;p) for the board (EA0T00) sets revert_y_flag = <0>;, and the driver (drivers/input/touchscreen/elants_i2c.c) sets revert_y_flag = !revert_y_flag; on 16Bits_mirror boards (NTXHWConfig DisplayBusWidth (35) is 3, which is in fact the case for that board), so, that would seem to track.

EDIT: Or not. That bit of code is behind a sunxi ifdef.

EDIT²: Then again, that same DTB also sets exchange_x_y_flag to 0, so we might be back to "it's not the right dtb" or... something.

TL;DR: I'm going to go with "fuck it", if it just happens to work, regardless of why ;p.

Copy link
Member

@Frenzie Frenzie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@NiLuJe NiLuJe merged commit 0db7509 into koreader:master Aug 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants