InputText/InputDialog: fix keyboard issue #10850
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fix issue introduced by 976aaf5: with full screen text editor and hiding the keyboard, a tap in the text area would show a new keyboard hiding the button allowing to save/close the text editor, getting us stuck there.
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Aug 27, 2023
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Aug 27, 2023
NiLuJe
added a commit
to NiLuJe/koreader
that referenced
this pull request
Aug 27, 2023
NiLuJe
added a commit
that referenced
this pull request
Sep 1, 2023
Move as much of the state tracking as possible inside VirtualKeyboard itself. InputDialog unfortunately needs an internal tracking of this state because it needs to know about it *before* the VK is shown, so we have to keep a bit of duplication in there, although we do try much harder to keep everything in sync (at least at function call edges), and to keep the damage contained to, essentially, the toggle button's handler. (Followup to #10803 & #10850)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix issue introduced by 976aaf5: with full screen text editor and hiding the keyboard, a tap in the text area would show a new keyboard hiding the button allowing to save/close the text editor, getting us stuck there.
See #10803 (comment)
This change is