Skip to content

Custom metadata: update Statistics db on metadata change #10894

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 13, 2023

Conversation

poire-z
Copy link
Contributor

@poire-z poire-z commented Sep 12, 2023

Followup to #10861 and #10869 : update metadata in Reading Statistics DB when they change, so that the book can be found on the next opening and previous statistics are not lost - and so that the updated title/authors are reflected in the reading statistics (calendar view, today timeline & the others).


This change is Reviewable

@poire-z poire-z added this to the 2023.09 milestone Sep 12, 2023
@poire-z poire-z requested a review from hius07 September 12, 2023 10:16
@hius07
Copy link
Member

hius07 commented Sep 12, 2023

All looks very good.
metadata_value_new is not used, I will remove it.
I'm thinking of imposing some restrictions on series_index, it should not exist without series itself.

@poire-z
Copy link
Contributor Author

poire-z commented Sep 13, 2023

I'm thinking of imposing some restrictions on series_index, it should not exist without series itself.

As you feel (I hardly ever have books with series, and I don't really know/care about how this works/looks).

@poire-z poire-z merged commit f78a8c5 into koreader:master Sep 13, 2023
@poire-z poire-z deleted the stats_metadata_update branch September 13, 2023 10:39
@Frenzie
Copy link
Member

Frenzie commented Sep 13, 2023

@poire-z On a completely unrelated note, your beautiful calendar is problematic. It's made me lazy about properly logging what I'm reading. ;-)

@poire-z
Copy link
Contributor Author

poire-z commented Sep 13, 2023

:)
I still log my reading (and movies watching) to a text file - easier to grep so I don't buy or reread the same books :)
So, as long as Statistics does not have a find feature, logging is still needed :)

@Frenzie
Copy link
Member

Frenzie commented Sep 13, 2023

I definitely still do that, just a bit late sometimes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants