Skip to content

TextViewer: font size #10911

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 9 commits into from
Sep 19, 2023
Merged

TextViewer: font size #10911

merged 9 commits into from
Sep 19, 2023

Conversation

hius07
Copy link
Member

@hius07 hius07 commented Sep 18, 2023

The DictQuickLookup and TextViewer windows are alike, let TextViewer use the same settings dict_font_size and dict_justify.


This change is Reviewable

@hius07 hius07 merged commit 684fc22 into koreader:master Sep 19, 2023
@hius07 hius07 deleted the textviewer-font-size branch September 19, 2023 05:39
@hius07 hius07 added this to the 2023.09 milestone Sep 19, 2023
@poire-z
Copy link
Contributor

poire-z commented Dec 4, 2023

Just a comment, not sure we need to do something.

The DictQuickLookup and TextViewer windows are alike, let TextViewer use the same settings

Been a bit annoyed since this PR, and to me they are not alike :)
I have my dict font size set to 17 - which is small, but fine with my non-"Large window" dict result window: as it is small and narrow, a small font size is fine, and I usually don't really "read" the whole dict result, I just quick scan it and may really read one or two sentences.
Getting the same tiny font size in eg. Book description, a large and tall window, that I may want to read fully, makes it have long lines of tiny text, and harder to read.

(I also have other TextViewer to see logs and various stuff in my own patch which got a bigger font size that the small one I set - I realize reading this PR that text_face = Font:getFace("infont", 12) won't work anymore, and I just need to use text_font_size = 12 instead.)

@Frenzie
Copy link
Member

Frenzie commented Dec 4, 2023

Ah, this PR is to blame for that. I'm inclined to agree. ^_^

@hius07
Copy link
Member Author

hius07 commented Dec 5, 2023

The separate setting would be good I believe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants