ReaderRolling: Guard against races between scheduled tasks and CloseDocument #10934
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
(Ping @poire-z for when he gets back ;)). |
Easy enough to avoid here, so, dooooooo iiiiitttttt!
poire-z
reviewed
Sep 22, 2023
Comment on lines
-1090
to
+1105
| UIManager:scheduleIn(0.1, function () | ||
| self:onCheckDomStyleCoherence() | ||
| end) | ||
| UIManager:scheduleIn(0.1, self.onCheckDomStyleCoherence, self) |
There was a problem hiding this comment.
I prefer the readability of the one with the function() wrapper - and for consistency with the others that may do just a bit more, like in your next chunk.
There was a problem hiding this comment.
It usually depends on my mood, but avoiding a closure here means we can easily unschedule it without storing a reference to the scheduled closure, so it's very much on purpose there (to get a simple, stable reference to the scheduled function).
(I'm not necessarily a fan of doing the guarding inside the closure like some of them do, for instance).
Frenzie
reviewed
Sep 23, 2023
Co-authored-by: Frans de Jonge <fransdejonge@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix #10932
This change is