Skip to content

coverbrowser: improve title & authors layout #10942

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

benoit-pierre
Copy link
Contributor

@benoit-pierre benoit-pierre commented Sep 24, 2023

  • handle possible height overflow
  • now that labels don't overflow, increase the minimum font size

Example, before:
2023-09-24-181215_540x720_scrot

And after:
2023-09-24-181145_540x720_scrot


This change is Reviewable

@Frenzie
Copy link
Member

Frenzie commented Sep 24, 2023

What's the quickest way to get some insanely long string in there? (I suppose the answer might be to hack the code. :-D)

@Frenzie Frenzie requested a review from poire-z September 24, 2023 16:24
@Frenzie Frenzie added the Plugin label Sep 24, 2023
@benoit-pierre
Copy link
Contributor Author

Or patch an epub with ebook-meta --authors=AUTHORS --title=TITLE.

@Frenzie
Copy link
Member

Frenzie commented Sep 24, 2023

But then I'd have to install calibre. :-)

Edit: nothing against calibre, but I have no need for it and then it sneaks into various file associations that are sometimes surprising.

@benoit-pierre
Copy link
Contributor Author

Here.
ebooks.zip

@Frenzie
Copy link
Member

Frenzie commented Sep 24, 2023

So on higher DPI it's minuscule but legible. Probably not the best idea regardless, but perhaps this (250+ DPI) is the design context.

Screenshot_20230924_190945

@benoit-pierre
Copy link
Contributor Author

Really hard to read on Kindle PW2.

@mergen3107
Copy link
Contributor

I have a book which is basically a huge collection of poems from authors (30+) from Russian Silver Age of Poetry :D don’t need to hack anything to see this tiny font

@hius07
Copy link
Member

hius07 commented Sep 24, 2023

What's the quickest way to get some insanely long string in there?

Custom metadata!

- handle possible height overflow
- now that labels don't overflow, increase the minimum font size
@benoit-pierre benoit-pierre force-pushed the pr/improve_coverbrowser_title_and_authors_layout branch from 5eff353 to 4c7ed5f Compare September 24, 2023 18:43
@Frenzie Frenzie added this to the 2023.09 milestone Sep 29, 2023
@Frenzie Frenzie merged commit 7d3456e into koreader:master Sep 29, 2023
@benoit-pierre benoit-pierre deleted the pr/improve_coverbrowser_title_and_authors_layout branch September 29, 2023 11:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants