File search, FileChooser and others

[hius07]

All is cross-bound, hence the combined PR.

(1) File search
File search now is available in the file browser only.
Standard file dialog pop-up buttons added. Closes #10991.

(2) File manager
Unapplicable pop-up buttons in the file dialog are hidden (previously they were disabled).

Supported file

Unsupported file

(3) FileChooser
"Show" settings (finished books, hidden files, unsupported files) are centralized in FileChooser.
Optimization: do not init the settings every time when FM is launched.

(4) Dispatcher
"File search" is moved from General to File browser section.
"Fulltext search" is moved from General to Reader section.
Tidy: lines of code are ordered in accordance with the action menu order, comments fixed/added.

(5) History
Finished books timestamp is dimmed if "Freeze last read date of finished books" is enabled.

---

This change is 

[Frenzie]

And in the context of the comment I just left this confuses me greatly. The newline provides the clarifying separation, what need is there for a visual distraction. :-P

[hius07]

Dashes because
-sections are divided with empty lines
-look like separators

koreader/frontend/ui/elements/filemanager_menu_order.lua

Lines 18 to 20 in 27104ea

	"sort_mixed",
	"----------------------------",
	"start_with",

[Frenzie]

Anyway, lgtm, though the impact is a little hard to gauge in places.

[poire-z]

Quite a lot to carefully read the whole thing.
But looks ok, and trusting you :)

(I thought the Dispatcher reorganisation was something I mentionned before at #10370 - but was happy to see it was taken care of in #10387, so not sure :) may be not completely, haven't reread these.)

[NiLuJe]

Reviewed 9 of 9 files at r1, all commit messages.
Reviewable status: all files reviewed, 4 unresolved discussions (waiting on @Frenzie and @hius07)

---

frontend/dispatcher.lua line 57 at r1 (raw file):

Previously, hius07 wrote…

Dashes because
-sections are divided with empty lines
-look like separators

koreader/frontend/ui/elements/filemanager_menu_order.lua

Lines 18 to 20 in 27104ea

	"sort_mixed",
	"----------------------------",
	"start_with",

I sort of like the idea, but I might go with four dashes to make it clearer that it's not just a leftover empty comment oir something. (Also, ---- means a HR in MarkDown, right, so it's not entirely random?).

---

frontend/dispatcher.lua line 127 at r1 (raw file):

    file_search = {category="none", event="ShowFileSearch", title=_("File search"), filemanager=true, separator=true},
    --
    -- go_to

Those two I'm mildly confused by, though. Was the intent to match the actual Menu layout, but those two aren't applicable to Dispatcher?

---

frontend/ui/widget/filechooser.lua line 460 at r1 (raw file):

    local setting = not self[mode]
    self[mode] = setting
    FileChooser[mode] = setting

I'm not necessarily a fan of having this both in the instance and the class.

I'd much prefer it be one or the other.

(no preference as to which, so go with whatever is more practical, likely the class).

(Note that, if it's nil in the instance, looking up the instance will go to the class anyway).

[hius07]

Was the intent to match the actual Menu layout, but those two aren't applicable to Dispatcher?

That was the intention.
go_to and back appears in two sections in the menu, but are coded once:

koreader/frontend/dispatcher.lua

Line 141 in 3b293f3

go_to = {category="none", event="ShowGotoDialog", title=_("Go to page"), filemanager=true, reader=true},

[hius07]

Note that, if it's nil in the instance, looking up the instance will go to the class anyway

And what is the benefit if of setting self[mode]=nil?
Looking up farther, from the instance to the class?

[NiLuJe]

And what is the benefit if of setting self[mode]=nil?
Looking up farther, from the instance to the class?

Not necessarily what I was going for ;).

I just meant that if a field isn't set in an instance, looking it up in said instance will resolve it in the class instead. (With the intent being that having the actual storage in the class means you don't necessarily have to hunt down every instance access to make them explicit class access instead... As long as nothing ever sets it in the instance, that is. Although, FWIW, I do prefer when class members are always explicitly accessed as such, and not via self ;)).

[hius07]

Oh, yes, this line can just be removed, thanks.