-
-
Notifications
You must be signed in to change notification settings - Fork 1.5k
Virtual keyboard: add a setting to disable swipes #11066
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Device:performHapticFeedback("KEYBOARD_TAP") | ||
if self.flash_keyboard and not self.skipswipe then |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Iirc that's intended for internal use (like on the shift key), regardless whether it's fully hooked up at this time. Basically see
koreader/frontend/ui/widget/virtualkeyboard.lua
Lines 62 to 64 in 58cb1ff
if self.keyboard.symbolmode_keys[self.label] ~= nil then | |
self.callback = function () self.keyboard:setLayer("Sym") end | |
self.skiptap = true |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But removing it is probably fine given it hasn't served any purpose the past x years.
The rest (95% :)) of changes in menu_keyboard_layout.lua is just refactoring, no UI/feature change, right? |
Minor UI changes: The main refactoring is: to iterate over both an array and a hash-table, I've changed "FFIUtil.orderedPairs + util.arrayContains" to "ipairs + table.sort(array)". |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
^ ok, not gonna follow all this, trusting you :)
Haven't checked the code, but I assume you meant EDIT: Okay, there aren't really any hashes directly involved anymore, just a hit check in the array loop. TL;DR: Looks sound at a glance ;). |
Array (active layouts) is not sorted alphabetically. |
Default to enable. Fixes #10976.
Cleanup.
This change is