Skip to content

VocabBuilder.koplugin: support batch operations in book filtering #11475

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Feb 18, 2024

Conversation

weijiuqiao
Copy link
Contributor

@weijiuqiao weijiuqiao commented Feb 18, 2024

Added support

  1. Select only this book
  2. Select all books
  3. Select all books on this page
  4. Deselect all books on this page

when filtering.

Ref. #11471


This change is Reviewable

@Frenzie Frenzie added this to the 2024.02 milestone Feb 18, 2024
@Frenzie Frenzie added the Plugin label Feb 18, 2024
@Frenzie Frenzie merged commit 5939c82 into koreader:master Feb 18, 2024
@Frenzie
Copy link
Member

Frenzie commented Feb 18, 2024

Thanks!

@weijiuqiao
Copy link
Contributor Author

No worries!

@poire-z
Copy link
Contributor

poire-z commented Feb 18, 2024

(If this closes #11471, do close it :))

@Frenzie
Copy link
Member

Frenzie commented Feb 18, 2024

We generally write "fix" or "close" when it does that (or "addresses" etc. but that's not an automatic GH keyword) while we normally use "references" to mean it somehow relates to or does only part of it.

Also don't write "partially fixes" because GH only reads the "fixes". ;-)

@weijiuqiao
Copy link
Contributor Author

Got it :)

@weijiuqiao weijiuqiao deleted the weijiuqiao-patch-1 branch April 4, 2024 06:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants