From 67862098427dbd6cf9e94aef7dacb320776ffc46 Mon Sep 17 00:00:00 2001
From: SomeGuy <97603719+Commodore64user@users.noreply.github.com>
Date: Sat, 4 May 2024 22:44:21 +0100
Subject: [PATCH 1/3] remove duplicated setting

---
 frontend/apps/reader/modules/readerhighlight.lua | 1 +
 1 file changed, 1 insertion(+)

diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua
index 77579c40111f..d1f1af0db8b4 100644
--- a/frontend/apps/reader/modules/readerhighlight.lua
+++ b/frontend/apps/reader/modules/readerhighlight.lua
@@ -594,6 +594,7 @@ Except when in two columns mode, where this is limited to showing only the previ
     if not Device:isTouchDevice() and Device:hasDPad() then
         menu_items.selection_text = util.tableDeepCopy(menu_items.long_press)
         menu_items.selection_text.text = _("Select on text")
+        menu_items.long_press = nil
     end
 
     -- main menu Search

From aefd8c131a002552d148c780e9249983df4bc15e Mon Sep 17 00:00:00 2001
From: SomeGuy <97603719+Commodore64user@users.noreply.github.com>
Date: Sat, 4 May 2024 23:23:51 +0100
Subject: [PATCH 2/3] minor comment-wording change

---
 frontend/apps/reader/modules/readerhighlight.lua | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua
index d1f1af0db8b4..b0d8553aad03 100644
--- a/frontend/apps/reader/modules/readerhighlight.lua
+++ b/frontend/apps/reader/modules/readerhighlight.lua
@@ -589,8 +589,8 @@ Except when in two columns mode, where this is limited to showing only the previ
         end,
     })
 
-    -- long_press menu is under taps_and_gestures menu which is not available for non touch device
-    -- Clone long_press menu and change label making much meaning for non touch devices
+    -- long_press setting is under taps_and_gestures menu which is not available for non-touch devices
+    -- Clone long_press setting and change its label, making it much more meaningful for non-touch device users.
     if not Device:isTouchDevice() and Device:hasDPad() then
         menu_items.selection_text = util.tableDeepCopy(menu_items.long_press)
         menu_items.selection_text.text = _("Select on text")

From e27e9f0914034ebda0a707b2c9bc8c829b726e50 Mon Sep 17 00:00:00 2001
From: SomeGuy <97603719+Commodore64user@users.noreply.github.com>
Date: Sat, 11 May 2024 11:50:34 +0100
Subject: [PATCH 3/3] tableDeepCopy removed as not needed

---
 frontend/apps/reader/modules/readerhighlight.lua | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/frontend/apps/reader/modules/readerhighlight.lua b/frontend/apps/reader/modules/readerhighlight.lua
index b0d8553aad03..d9a3343b0a9e 100644
--- a/frontend/apps/reader/modules/readerhighlight.lua
+++ b/frontend/apps/reader/modules/readerhighlight.lua
@@ -592,8 +592,8 @@ Except when in two columns mode, where this is limited to showing only the previ
     -- long_press setting is under taps_and_gestures menu which is not available for non-touch devices
     -- Clone long_press setting and change its label, making it much more meaningful for non-touch device users.
     if not Device:isTouchDevice() and Device:hasDPad() then
-        menu_items.selection_text = util.tableDeepCopy(menu_items.long_press)
-        menu_items.selection_text.text = _("Select on text")
+        menu_items.selection_text = menu_items.long_press
+        menu_items.selection_text.text = _("Selection on text")
         menu_items.long_press = nil
     end