Skip to content

Conversation

@hius07
Copy link
Member

@hius07 hius07 commented May 24, 2024

Fixes #11476 (comment).


This change is Reviewable

@poire-z
Copy link
Contributor

poire-z commented May 24, 2024

Tested, and it solves the destruction of the docsettings.
(But there is no popup "1 file was not moved" like I get on the emulator.)

@hius07
Copy link
Member Author

hius07 commented May 24, 2024

The result of copying/moving a file to itself is the unchanged file system.
I think we do not need any error message.

@poire-z
Copy link
Contributor

poire-z commented May 24, 2024

But we have the message on the emulator - I'm just thinking consistency.
If you tell me it's just hard to get it too in this case, then I'm fine with not having it :) it's just a edge case.

@Frenzie Frenzie added this to the 2024.06 milestone May 24, 2024
@hius07 hius07 merged commit 076f772 into koreader:master May 26, 2024
@hius07 hius07 deleted the fm-fix-paste-itself branch May 26, 2024 05:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants