Skip to content

Conversation

@NiLuJe
Copy link
Member

@NiLuJe NiLuJe commented Jun 4, 2024

  • Actually log failures, besides showing the completely unhelpful InfoMessage.
  • Handle searches on Calibre.
  • Fix content fill on pagination. I have no frickin' clue how the hell this ever worked, as it was using the wrong handler name.

Fix #11968

(Rebase me).


This change is Reviewable

NiLuJe added 3 commits June 4, 2024 19:02
I have... no idea how this could have ever worked, the Menu handler has
*always* been called OnNextPage o_O.
We don't want to actually change the page when we request a fill on the
initial fetch.
@NiLuJe NiLuJe added the bug label Jun 4, 2024
@NiLuJe NiLuJe added this to the 2024.06 milestone Jun 4, 2024
@Frenzie Frenzie merged commit 08f02bf into koreader:master Jun 4, 2024
@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 5, 2024

  • I have no frickin' clue how the hell this ever worked, as it was using the wrong handler name.

I can only assume there was a point in time where the OPDSBrowser subclass was reinventing the wheel and re-implementing the navigation arrows with a different handler, because I could have sworn this used to work for realz.

@Frenzie
Copy link
Member

Frenzie commented Jun 5, 2024

I think it did, yes.

@NiLuJe
Copy link
Member Author

NiLuJe commented Jun 5, 2024

Note that we don't handle the "last page" link at all, because that would require being able to backfill the gaps between the current content and the tail of the content, and I don't even want to start thinking about that ;p.

So, right now, our last page chevron jumps to the last page of the currently loaded content, and won't request more content (which means you need to page backward and then forward again to get more stuff).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

OPDS Connection to Calibre does not display all books. Only in Title View.

2 participants