-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
InputContainer: consistent input type in onInput() #12012
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Not sure we if we really want to change the variable name (mainly for backwards compat, especially with 3rd-party plugins; otherwise I'd agree with you that the current name isn't great ;)) ;). Good idea to clean this up, though, thanks! |
They would get the main (letters) layer of the keyboard instead of the numeric (symbol) layer, that's it, not a big issue I believe. |
|
Just updated a minute ago, but still have issue #11990, so I suppose I still got a nightly from before the update. Will try again tomorrow. |
|
Yup, the merge came juuuust after the nightly build (~6AM GMT) ;). |
|
Hmm.. I just now checked, and got "KOReader is up to date" - but the keyboard issue persists. |
|
It missed the deadline for the nightly, try tomorrow. |
Closes #11990.
This change is