pocketbook: support "extended" key events#12707
Conversation
NiLuJe
left a comment
There was a problem hiding this comment.
Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status:complete! all files reviewed, all discussions resolved (waiting on @benoit-pierre)
|
Hey @benoit-pierre, me again. I'm still running an ad-hoc patch you've sent here koreader/koreader-base#1970 (comment) and I want to report a crash during using it. The crash is super rare (3 books finished, 2 times crashed, so far) and unfortunately I could not deliberately reproduce it. My observations are: it's not caused by reading itself. During my reading sessions I use different ways of turning pages (hardware on-device buttons, touch screen and designated right-center area, touch screen and a custom right-bottom corner command, and The Gamepad) – it works great and never crashed. Also I'm able to use highlights with touching and dragging over the screen, no crashed either. I believe, but not entirely sure, that both times it threw, I was traversing through some menus like "book description" in the library view, not the book reader view. Unfortunately, I only have the last log, the first one happened last week and was truncated. So, here's an excerpt: And the full session log is attached in a zip. |
|
@tommiv: updated |
|
@benoit-pierre replaced, thanks, I'll let you know if I ever encounter a crash again |
52d5fbb to
0fcfad6
Compare
Only for device running with SDK >= 6.
0fcfad6 to
598025d
Compare
Only for devices running with SDK >= 6. Close koreader#12703.
Only for device running with SDK >= 6.
Close #12703.
This change is