Skip to content

pocketbook: support "extended" key events#12707

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/inkview_sdk_v6_update
Nov 20, 2024
Merged

pocketbook: support "extended" key events#12707
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/inkview_sdk_v6_update

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Nov 4, 2024

Copy link
Copy Markdown
Member

Only for device running with SDK >= 6.

Close #12703.


This change is Reviewable

@NiLuJe NiLuJe left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reviewed 2 of 2 files at r1, all commit messages.
Reviewable status: :shipit: complete! all files reviewed, all discussions resolved (waiting on @benoit-pierre)

@tommiv

tommiv commented Nov 13, 2024

Copy link
Copy Markdown

Hey @benoit-pierre, me again. I'm still running an ad-hoc patch you've sent here koreader/koreader-base#1970 (comment) and I want to report a crash during using it.

The crash is super rare (3 books finished, 2 times crashed, so far) and unfortunately I could not deliberately reproduce it.

My observations are: it's not caused by reading itself. During my reading sessions I use different ways of turning pages (hardware on-device buttons, touch screen and designated right-center area, touch screen and a custom right-bottom corner command, and The Gamepad) – it works great and never crashed. Also I'm able to use highlights with touching and dragging over the screen, no crashed either. I believe, but not entirely sure, that both times it threw, I was traversing through some menus like "book description" in the library view, not the book reader view.

Unfortunately, I only have the last log, the first one happened last week and was truncated. So, here's an excerpt:

11/11/24-23:46:43 DEBUG slot 0 in hold state... 
11/11/24-23:46:43 DEBUG PB event => 31 (EVT_POINTERMOVE), par1: 1371, par2: 1862 
11/11/24-23:46:43 DEBUG PB event => 39 (EVT_MTSYNC), par1: 2, par2: 2 
./luajit: ./ffi/input_pocketbook.lua:144: attempt to perform arithmetic on 'struct iv_mtinfo_s *' and 'number'
stack traceback:
	./ffi/input_pocketbook.lua:144: in function <./ffi/input_pocketbook.lua:108>
	[C]: in function 'ProcessEventLoop'
	./ffi/input_pocketbook.lua:429: in function 'waitForEvent'
	frontend/device/input.lua:1399: in function 'waitEvent'
	frontend/ui/uimanager.lua:1535: in function 'handleInput'
	frontend/ui/uimanager.lua:1590: in function 'run'
	./reader.lua:265: in main chunk
	[C]: at 0x00013f61
Process has been terminated by signal {SIGSEGV::SEGV_MAPERR}
Segmentation fault

And the full session log is attached in a zip.

full-session-crash.log.zip

@benoit-pierre

Copy link
Copy Markdown
Member Author

@tommiv: updated ffi/inkview_h.lua.

@tommiv

tommiv commented Nov 13, 2024

Copy link
Copy Markdown

@benoit-pierre replaced, thanks, I'll let you know if I ever encounter a crash again

@benoit-pierre benoit-pierre force-pushed the pr/inkview_sdk_v6_update branch from 52d5fbb to 0fcfad6 Compare November 20, 2024 20:17
Only for device running with SDK >= 6.
@benoit-pierre benoit-pierre force-pushed the pr/inkview_sdk_v6_update branch from 0fcfad6 to 598025d Compare November 20, 2024 20:21
@benoit-pierre benoit-pierre marked this pull request as ready for review November 20, 2024 20:21
@Frenzie Frenzie added this to the 2025.01 milestone Nov 20, 2024
@Frenzie Frenzie merged commit 24f983b into koreader:master Nov 20, 2024
@benoit-pierre benoit-pierre deleted the pr/inkview_sdk_v6_update branch November 20, 2024 20:52
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Only for devices running with SDK >= 6.

Close koreader#12703.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Bluetooth keyboard events are handled as EVT_TOUCHDOWN / EVT_TOUCHUP on Pocketbook

4 participants