Highlight: line height#12721
Merged
Merged
Conversation
Contributor
|
Nice features! I would rename Edit to Highlight Menu and Note to Edit (Because "Note" is in the title, "Edit" is assumed to refer to this note.)
|
Contributor
|
I think I brought this up before but the Delete button can be equally misunderstood. Because Note is in the title, Delete would/could be assumed to just this note, and not the entire highlight & note combo. Personally, I would have the Delete button just delete the note, and leave the highlight alone. The entire combo can still be deleted quickly via Highlight Menu -> Delete. Or the button could be renamed to the Delete highlight & note. This is rather long, unfortunately, but would minimize inadvertent deletions due to misunderstanding of this option. |
Member
Author
|
|
Frenzie
approved these changes
Nov 20, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(After the release)
(1) Adjustable highlight line height. Discussed in #10416 and #11581.
(2) "Note" button in the Note window (on tapping a highlight with note). Closes #12234.
This change is