Skip to content

Screenshoter: fix screenshot folder - #12750

Merged
Frenzie merged 2 commits into
koreader:masterfrom
hius07:screenshot-dir
Nov 20, 2024
Merged

Frenzie merged 2 commits into
koreader:masterfrom
hius07:screenshot-dir

Conversation

@hius07

@hius07 hius07 commented Nov 18, 2024 •

Copy link
Copy Markdown
Member

Check for existance and create if absent.
Closes #12742.


This change is Reviewable

@NiLuJe

NiLuJe commented Nov 18, 2024

Copy link
Copy Markdown
Member

Oops, skipped over the CI: frontend/ui/widget/screenshoter.lua:103:39: shadowing upvalue argument caller_callback on line 49 ;).

@hius07

hius07 commented Nov 18, 2024 •

Copy link
Copy Markdown
Member Author

CircleCI error message

Found ninja-1.10.0 at /usr/bin/ninja
ninja: build stopped: subcommand failed.
make: *** [base/Makefile:89: base-all] Error 1

@benoit-pierre can you help with this?

@benoit-pierre

Copy link
Copy Markdown
Member

sigh

Something changed on CircleCI's side, so we're trying to build with too many jobs again:

************ NINJA: ninja -j54 -l36 **********
************ MAKE: make -j54 -l36 **********

@hius07

hius07 commented Nov 18, 2024

Copy link
Copy Markdown
Member Author

Dunno if it's related, a notice from them:

Notice: If you are using "when: always" in your workflow filters, update to "when: true" to avoid configuration failures.

@benoit-pierre

Copy link
Copy Markdown
Member

Dunno if it's related, a notice from them:

Notice: If you are using "when: always" in your workflow filters, update to "when: true" to avoid configuration failures.

Confusing and misleading, this does not apply to our case (Cf. https://circleci.com/changelog/dynamic-when-statements-breaking-change/):

NOTE: When in Steps are not impacted by this change.

tap_close_callback = function(caller_callback)
if caller_callback then
tap_close_callback = function()
if type(caller_callback) == "function" then

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Err, can it be anything else?

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, ges_event sends a gesture object as the second arg.

Copy link
Copy Markdown
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Screenshoter.onKeyPressShoot = Screenshoter.onScreenshot
Screenshoter.onTapDiagonal = Screenshoter.onScreenshot
Screenshoter.onSwipeDiagonal = Screenshoter.onScreenshot

@Frenzie Frenzie added this to the 2025.01 milestone Nov 20, 2024
@Frenzie
Frenzie merged commit 2b763c7 into koreader:master Nov 20, 2024
@hius07
hius07 deleted the screenshot-dir branch November 21, 2024 05:54
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Check for existance and create if absent.
Closes koreader#12742.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Screenshots missing when taken when there is no folder for them

4 participants