Highlights: page boxes cache#12768
Merged
Merged
Conversation
poire-z
approved these changes
Nov 21, 2024
poire-z
left a comment
poire-z
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me, really zero comment.
Comment on lines
-1054
to
-1057
| -- Getting screen boxes is done for each tap on screen (changing pages, | ||
| -- showing menu...). We might want to cache these boxes per page (and | ||
| -- clear that cache when page layout change or highlights are added | ||
| -- or removed). |
Contributor
There was a problem hiding this comment.
A quick first reading, and I was sad seeing again my cherished comments disappearing - but you're actually implementing exactly this one :) So, good riddance !
Member
Author
There was a problem hiding this comment.
Thanks, your fruitful comments will not be forgotten!
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(1) Always save visible highlight boxes in the current page, to be used when tapping the page.
(2) When possible ("page" view modes) save page highlight boxes, to be used when drawing already visited pages.
This
koreader/frontend/apps/reader/modules/readerview.lua
Lines 571 to 574 in 93f2fa6
This change is