Skip to content

Collections: search#12776

Merged
hius07 merged 5 commits intokoreader:masterfrom
hius07:coll-search
Dec 4, 2024
Merged

Collections: search#12776
hius07 merged 5 commits intokoreader:masterfrom
hius07:coll-search

Conversation

@hius07
Copy link
Copy Markdown
Member

@hius07 hius07 commented Nov 22, 2024

Search in collections for books containing the search string in the filename (not in the path) or in the metadata (from CoverBrowser sql or from sdr, without opening a book).
Search results (if any) are saved to a new collection and it is displayed (not shown in the screenshots below).
Search results are sorted at first by collections order, then by books order in a collection.

1

2

3

We have a lot of search types:

4


This change is Reviewable

@jonnyl2
Copy link
Copy Markdown
Contributor

jonnyl2 commented Nov 25, 2024

Tested and everything worked fine.

I personally don't mind the searches being saved permanently as new collections, but this might be confusing to some users. Perhaps add an option in the hamburger menu, Clear previous searches, or similar? This would serve 2 purposes: 1) Clear all searches at once (duh..), and 2) Signal to the user that searches being stored as new collections is the normal behavior.

image

@hius07 hius07 merged commit 58adb68 into koreader:master Dec 4, 2024
@hius07 hius07 deleted the coll-search branch December 4, 2024 12:09
@hius07 hius07 added this to the 2025.01 milestone Dec 4, 2024
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants