Skip to content

tests: speedup persist huge tables test#12786

Merged
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/speedup_slow_persist_huge_tables_test
Nov 23, 2024
Merged

tests: speedup persist huge tables test#12786
Frenzie merged 1 commit into
koreader:masterfrom
benoit-pierre:pr/speedup_slow_persist_huge_tables_test

Conversation

@benoit-pierre

@benoit-pierre benoit-pierre commented Nov 23, 2024

Copy link
Copy Markdown
Member

For example on my machine:

test duration (ms) master PR
regular run 859.82 104.38 (÷8.2)
coverage run 40735.60 4151.34 (÷9.8)

This change is Reviewable

For example on my machine:

| test duration (ms) |  master  |             PR |
| :-                 | -:       | -:             |
| regular run        |   859.82 |  104.38 (÷8.2) |
| coverage run       | 40735.60 | 4151.34 (÷9.8) |

@Frenzie Frenzie left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fine by me

@Frenzie
Frenzie requested a review from NiLuJe November 23, 2024 16:53
@Frenzie Frenzie added this to the 2025.01 milestone Nov 23, 2024
@Frenzie
Frenzie merged commit 64dabfa into koreader:master Nov 23, 2024
@benoit-pierre
benoit-pierre deleted the pr/speedup_slow_persist_huge_tables_test branch November 23, 2024 18:30
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
For example on my machine:

| test duration (ms) |  master  |             PR |
| :-                 | -:       | -:             |
| regular run        |   859.82 |  104.38 (÷8.2) |
| coverage run       | 40735.60 | 4151.34 (÷9.8) |
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants