Skip to content

webdav: show folders with same name as current folder#12788

Merged
Frenzie merged 2 commits into
koreader:masterfrom
BrendanL79:issue-12783-webdav-folder-fix
Nov 24, 2024
Merged

webdav: show folders with same name as current folder#12788
Frenzie merged 2 commits into
koreader:masterfrom
BrendanL79:issue-12783-webdav-folder-fix

Conversation

@BrendanL79

@BrendanL79 BrendanL79 commented Nov 23, 2024

Copy link
Copy Markdown
Contributor

Tested and confirmed to work even when the subfolder name appears multiple times in the current folder's full path.
Closes #12783


This change is Reviewable

@mergen3107

Copy link
Copy Markdown
Contributor
  1. Please add a comment in your first post that says "Closes URL", where URL is your original ticket. This will make GitHub close that issue once this PR is merged.

  2. And you also don't have phantom folders too? See linked issue that I opened before (and because of which that PR was created).

Say, in folder a/a/, do you see phantom folder "a"?

@BrendanL79

Copy link
Copy Markdown
Contributor Author
  1. Please add a comment in your first post that says "Closes URL", where URL is your original ticket. This will make GitHub close that issue once this PR is merged.

    1. And you also don't have phantom folders too? See linked issue that I opened before (and because of which that PR was created).

Say, in folder a/a/, do you see phantom folder "a"?

No phantom folders! :)
Screenshot 2024-11-23 204244

@mergen3107

Copy link
Copy Markdown
Contributor

Awesome! Thanks!

@hius07 hius07 added the bug label Nov 24, 2024
@hius07 hius07 added this to the 2025.01 milestone Nov 24, 2024
@Frenzie Frenzie merged commit 798a649 into koreader:master Nov 24, 2024
@BrendanL79 BrendanL79 deleted the issue-12783-webdav-folder-fix branch November 24, 2024 14:27
0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Cloud storage / WebDAV: folder is invisible if it has the same name as the current folder

4 participants