switch to new meson based testsuite runner#12789
Merged
Frenzie merged 9 commits intoNov 25, 2024
Merged
Conversation
This was referenced Nov 24, 2024
Merged
benoit-pierre
force-pushed
the
pr/switch_to_new_meson_based_testsuite_runner
branch
3 times, most recently
from
November 24, 2024 22:20
2064e4f to
115e595
Compare
benoit-pierre
marked this pull request as ready for review
November 24, 2024 22:21
benoit-pierre
marked this pull request as draft
November 25, 2024 00:53
Use the `KO_HOME` environment variable if set to determine the data directory location.
Factorize and use a proper separate test for each benchmark. Note: only open the 9 fist pages (reduce memory so benchmarks can be run on more limited memory devices, like the Kindle).
benoit-pierre
force-pushed
the
pr/switch_to_new_meson_based_testsuite_runner
branch
from
November 25, 2024 20:06
115e595 to
f89508e
Compare
benoit-pierre
marked this pull request as ready for review
November 25, 2024 20:06
Frenzie
reviewed
Nov 25, 2024
Frenzie
approved these changes
Nov 25, 2024
Instead of running the testsuite twice when coverage is need, only run it once (without filtering out `nocov` tests): with `cluacov` installed, it's only 50% slower than a normal run.
Drop `nocov` tag for tests already tagged with `notest` (already ignored when doing a coverage run).
Don't exclude `nocov` tests, since on master, only one run with coverage is used.
benoit-pierre
force-pushed
the
pr/switch_to_new_meson_based_testsuite_runner
branch
from
November 25, 2024 21:47
f89508e to
eeba34f
Compare
So it's picked up by the bench testsuite.
benoit-pierre
deleted the
pr/switch_to_new_meson_based_testsuite_runner
branch
November 25, 2024 22:00
Member
Author
Somehow I doubt this cache is going to be much help… ;( |
Member
Author
|
And indeed, an empty cache was saved… |
Member
|
Not found? Strange indeed. O.o |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
On Circle CI, we can drop the parallelism, halving resources. On master, instead of 3 different runs (normal, coverage, and test results for timings), we can run the full suite one time with coverage, all the while reducing the build job wall-clock time: 2m 19s → 1m 13s.
This change is