Skip to content

remove autofrontlight + backgroundrunner#12809

Merged
pazos merged 5 commits into
koreader:masterfrom
pazos:autofrontlight
Dec 6, 2024
Merged

remove autofrontlight + backgroundrunner#12809
pazos merged 5 commits into
koreader:masterfrom
pazos:autofrontlight

Conversation

@pazos

@pazos pazos commented Nov 27, 2024

Copy link
Copy Markdown
Member

The plugin cannot be moved to contrib as is. It relies on the backgroundrunner plugin, no longer available. It needs to be updated to execute their tasks based on events or similar.


This change is Reviewable

@Frenzie

Frenzie commented Nov 27, 2024

Copy link
Copy Markdown
Member

There's also the spec file (see CI).

@pazos pazos marked this pull request as draft November 28, 2024 19:59
@pazos pazos changed the title remove autofrontlight remove autofrontlight + backgroundrunner Nov 28, 2024
@pazos

pazos commented Nov 29, 2024

Copy link
Copy Markdown
Member Author

There's also the spec file (see CI).

Thanks! Done!

Also removed the backgrounrunner plugin.

@pazos pazos requested a review from NiLuJe November 29, 2024 15:16
@pazos pazos marked this pull request as ready for review December 1, 2024 23:42
@Frenzie Frenzie added this to the 2025.01 milestone Dec 5, 2024
@pazos pazos merged commit 162685d into koreader:master Dec 6, 2024
@pazos pazos deleted the autofrontlight branch December 6, 2024 20:28
@Hzj-jie

Hzj-jie commented Dec 23, 2024

Copy link
Copy Markdown
Contributor

As I have mentioned in one of the previous change, this is one of the very important reasons I chose a voyage. It seems a very poor decision to remove a fine working feature because "I do not use it". The statement of It relies on the backgroundrunner plugin, no longer available is also very confusion. Why doesn't it work?

@pazos

pazos commented Dec 23, 2024

Copy link
Copy Markdown
Member Author

@Hzj-jie: Please try to enable "some" github notifications. I've tried to warn you in advance: #12854 (comment)

The reason for removal of the backgroundrunner is in #12637 and was agreed between current maintainers.

The reason for removal of the autofrontlight is: it seems a trivial plugin that can be reimplemented standalone (without relying on the backgroundrunner). It is also enabled by default, which causes troubles with new users trying to understand why the program doesn't abide to the settings they setup.

A good place for the plugin (as-is sans the backgroundrunner dependencies) is contrib. I think nobody here will opose to have the plugin back this repo as long as its behaviour is opt-in.

@Frenzie

Frenzie commented Dec 23, 2024

Copy link
Copy Markdown
Member

It goes back to #12567 (comment) and #12567 (comment)

(though I don't necessarily agree with the it should be disabled by default pov)

Apologies for not pinging you at the time.

I don't think anyone's against reintroducing it slightly updated.

@pazos

pazos commented Dec 23, 2024

Copy link
Copy Markdown
Member Author

Just closed some related tickets. If/when the plugin is reintroduced I will open them again. Nothing is final here.

0xstillb pushed a commit to 0xstillb/koreader-thai that referenced this pull request May 9, 2026
* remove autofrontlight
* remove background-runner

thirparty plugins that rely on the backgroundrunner no longer work.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants