FileManager: Plus dialog button from CoverBrowser#12857
Conversation
|
Nice cleanup! Friday night, so, take this with a grain of salt, but nothing jumps out ;). |
| }) | ||
| end | ||
|
|
||
| local extract_button = self.coverbrowser and self.coverbrowser:genExtractBookInfoButton(close_dialog_callback) |
There was a problem hiding this comment.
(Not fond of seeing named references to a plugin in core - but you have already done that a lot, so ok :))
There was a problem hiding this comment.
I do hope one day you will agree it deserves to be moved to the core, it's the basis of the library.
There was a problem hiding this comment.
Besides of the view, the database part is important. As we have measured, the sql request is faster than doc_settings opening.
There was a problem hiding this comment.
I support someone other than me doing it. 😇
There was a problem hiding this comment.
I do hope one day you will agree it deserves to be moved to the core
I have nothing against that (see #8472 (comment)) - as long as the database is still considered just a cache and trashable (and disable'able if possible).
I support someone other than me doing it.
It's huge work, so: me too :)
5 participants
The Plus dialog doesn't need an api, just fetch the button from the CoverBrowser.
This change is