Patch management: plugin -> core - #12862
Conversation
|
Just a question. Isn't there a one_time_migration necessary to delete an already installed plugin? |
|
Sure, thanks! |
| -- 20241207, Move PatchManagement plugin to the core | ||
| -- https://github.com/koreader/koreader/pull/12862 | ||
| if last_migration_date < 20241207 then | ||
| logger.info("Performing one-time migration for 20241207") | ||
|
|
||
| ffiUtil.purgeDir(DataStorage:getDataDir() .. "/plugins/patchmanagement.koplugin") |
There was a problem hiding this comment.
The wording of the comment should probably read as:
-- We moved patch management to core. Remove the original plugin.
(This migration step does not "Move PatchManagement plugin to the core", you did :))
|
Wondering: |
|
koreader/frontend/pluginloader.lua Lines 8 to 10 in 157c03c They will not be loaded in any case, I can add purging them here. @pazos ? |
|
I'm not an expert in migrations. All the removed plugins until now we're not actively removed, just blacklisted. I'm fine with this approach but if you think it worths to remove them we can do delete them all and remove the obsolete array |
|
Some of them might have data that's important for a move to contrib. (Emphasis on might, if they don't they can probably be deleted.) |
|
I would be fine with not deleting previously installed plugins, as they are disabled. But the patchmanagement should be removed, other ways we have it twice. |
|
The OBSOLETE plugins are not just disabled, they are not visible in the Plugin management and cannot be enabled. |
|
Purging Patch management only. |
4 participants
Discussed in #12841.
This change is